Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rules_sass and send build metadata to Buildbuddy #1839

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove rules_sass and send build metadata to Buildbuddy #1839

wants to merge 5 commits into from
+28 −33

Commits on Dec 6, 2022

  1. Remove rules_sass which is no longer needed 

    The rules were formerly used by skydoc.
    @avdv
    avdv committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5a96bef View commit details
    Browse the repository at this point in the history

  2. Ensure build metadata for Buildbuddy is populated 

    Inside a pure nix shell, the `GITHUB_*` environment variables are not set and Buildbuddy
cannot determine metadata automatically.

See https://www.buildbuddy.io/docs/guide-metadata/
    @avdv
    avdv committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    fcc1404 View commit details
    Browse the repository at this point in the history

  3. Use the generated Bazel config for run-start-script 

    This enables taking advantage of Buildbuddy's cache.
    @avdv
    avdv committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    73c964c View commit details
    Browse the repository at this point in the history

  4. Skip writing to the remote cache with no API key 

    For PRs from forks (and also dependabot) access to the repository secrets is not
permitted, so the API key for Buildbuddy ends up as empty.

This would lead to an error:
```
WARNING: BES was not properly closed
ERROR: The Build Event Protocol upload failed: Not retrying publishBuildEvents, no more attempts left: status='Status{code=UNAUTHENTICATED, description=failed to parse AP
```
    @avdv
    avdv committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3ef8023 View commit details
    Browse the repository at this point in the history

  5. Generate common Bazel CI settings using a helper script

    @avdv
    avdv committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bfdf529 View commit details
    Browse the repository at this point in the history