Validate hidden modules #1796
Validate hidden modules #1796
Conversation
There was a problem hiding this comment.
Thanks for looking into this!
You can find tests for haskell_module here and tests for hidden modules here.
One possible way to test this would be to use failure testing.
| hidden_minus_declared_modules = set.difference(set.from_list(ctx.attr.hidden_modules), set.from_list(declared_modules)) | ||
| if not hidden_minus_declared_modules == set.empty(): | ||
| fail("""Hidden modules must be a subset of all modules, found additional hidden modules {}""".format(set.to_list(hidden_minus_declared_modules))) |
|
Here is the result of running
How do I make sure this gets run with the rest of the tests? |
CI invokes |
|
some of these tests failures that don't seem to have anything to do with this work... Do you see anything related to this PR in the output? |
It's the formatting test that fails. You can reformat your code by invoking buildifier on it ( |
Yeah it seems like it doesn't always run automatically for external PRs, but when I pushed the branch of the same name to this repo, it triggered... weird |
Yes, that's unfortunately how it is at the moment. It's the same issue as described here: tweag/rules_nixpkgs#243. |
|
CI is failing pretty spectacularly on windows |
fixes #1687
I tested this by just manually tweaking test files and monitoring for errors, because I was unsure of how to write a test expecting a failure. If one is required, can you please point me to an example?