Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add development instructions to README.md #28

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add development instructions to README.md #28

merged 1 commit into from
Jan 9, 2023

Conversation

mknorps
Copy link
Collaborator

@mknorps mknorps commented Dec 30, 2022

Solves #14 for a current state of the project.

Should be updated when #15 is solved.

@mknorps mknorps linked an issue Dec 30, 2022 that may be closed by this pull request
Documentation: development process #14
Closed
jherland
jherland approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem merging this as-is and then revisiting it closer to release.

Alternatively - since many things are still in flux - we can consider delaying this work until things are more settled down for the first release?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@mknorps
Copy link
Collaborator Author

mknorps commented Jan 4, 2023

Alternatively - since many things are still in flux - we can consider delaying this work until things are more settled down for the first release?

I think we can do this just before publishing the package, as there is only three of us working on it now and we already established our paths.
We can keep the PR not to forget about updating readme though.

@Nour-Mws
Copy link
Collaborator

Nour-Mws commented Jan 4, 2023

We can keep the PR not to forget about updating readme though.

In the meantime, can we convert the PR to draft?

@mknorps
Copy link
Collaborator Author

mknorps commented Jan 5, 2023

-> Merge this PR even if not perfect, dd information to update README when merging other PRs

@mknorps mknorps merged commit 4110959 into main Jan 9, 2023
@mknorps mknorps deleted the 14-documentation-development-process branch January 9, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jherland jherland jherland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: development process
3 participants
@mknorps @Nour-Mws @jherland