Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rephrase GitHub Actions in terms of Nox actions
This reduces duplication of GitHub vs local/Nox CI actions by changing the GitHub actions to call out to Nox. That said, this is not a full-fledged embrace of the Nox way: Nox will usually install dependencies in its own virtualenvs. However, these would come in addition to Poetry's virtualenv, and we have not currently set up caching for anything but the Poetry virtualenvs. Work around this by setting up the appropriate Python versiion and installing all the necesary dependencies in the Poetry virtualenv (i.e. outside of Nox). We can then run Nox with --no-venv --no-install to explicitly disable the Nox virtualenvs (which also disables the Python version paramtetrization inside Nox). For this to work, we also need to adjust our install_groups() helper in noxfile.py to detect when it's running without Nox virtualenvs and skip installation in this case. In summary, this avoids an extra layer of virtualenvs and should also retain the same useful caching of the Poetry virtualenvs, but at the cost of running the Nox sessions in a slightly different way compared to running Nox in your local development environment: We do Python version parametrization and dependency installation the Github Actions + Poetry way, and then only use Nox to abstract away the actual commands run inside each CI action. Time will tell if this creates too many issues to be worthwhile.
- Loading branch information