This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking aloud
.input-group
contains a<select>
/<textarea>
) ➜ Works now with<select>
/<textarea>
with the.form-control
/.custom-select
classes respectively (https://getbootstrap.com/docs/4.1/components/input-group/#custom-select/https://getbootstrap.com/docs/4.1/components/input-group/#basic-example) ➜ Replace with new checks in future ([v1] (Possible) checks to be added #424) but remove for now.input-group
s can cause issues.) ➜ Still applies? ➜ Change.input-lg
into.form-control-lg
.form-control
s) ➜ Works at least with multiple<input>
s except for validation (https://getbootstrap.com/docs/4.1/components/input-group/#multiple-inputs) ➜ Warning? Remove for now.and
.form-groupcannot be used directly on the same element) ➜ Still applies I guess ➜ Port by adding
row/
.form-row`and
.col--` cannot be used directly on the same element) ➜ PortChanges
E006, E010, E015 removed and E009, E011, E012, E044 ported
Status