This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Explicitly ignore containers within navbar for E004 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bootlint.js
Outdated
| @@ -409,7 +409,9 @@ var LocationIndex = _location.LocationIndex; | |||
| } | |||
| }); | |||
| addLinter("E004", function lintNestedContainers($, reporter) { | |||
| var nestedContainers = $('.container, .container-fluid').children('.container, .container-fluid'); | |||
| var nestedContainers = $('.container, .container-fluid').filter(function(i, div) { | |||
| return $(this).find('.navbar').length === 0; | |||
There was a problem hiding this comment.
indentation is off here. Use 4 spaces per indentation please. This should begin at column 12.
|
Argh. Had my editor set for work indentation. Will fix when I get home. |
src/bootlint.js
Outdated
| @@ -409,7 +409,9 @@ var LocationIndex = _location.LocationIndex; | |||
| } | |||
| }); | |||
| addLinter("E004", function lintNestedContainers($, reporter) { | |||
| var nestedContainers = $('.container, .container-fluid').children('.container, .container-fluid'); | |||
| var nestedContainers = $('.container, .container-fluid').filter(function () { | |||
| return $(this).find('.navbar').length === 0; | |||
There was a problem hiding this comment.
Can be simplified to .not(':has(.navbar)').
There was a problem hiding this comment.
All this time I'd been fighting cheerio with a .find(':not(.navbar)') check. I'll make the change.
| @@ -409,7 +409,7 @@ var LocationIndex = _location.LocationIndex; | |||
| } | |||
| }); | |||
| addLinter("E004", function lintNestedContainers($, reporter) { | |||
| var nestedContainers = $('.container, .container-fluid').children('.container, .container-fluid'); | |||
| var nestedContainers = $('.container, .container-fluid').not(':has(.navbar)').find('.container, .container-fluid'); | |||
There was a problem hiding this comment.
This logic seems wrong. Consider:
<div class="container">
<div class="navbar"></div>
<div class="container"></div>
</div>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #215
.navbar