Merge pull request #4 from tuyennn/feature/refactoring-js

[feat] Refactoring javascript
tuyennn · Oct 24, 2024 · 13586be · 13586be
2 parents da65e90 + deb5508
commit 13586be
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/view/base/web/js/view/payment/kbankjs-client.js b/view/base/web/js/view/payment/kbankjs-client.js
@@ -2,7 +2,6 @@ define([
     'jquery',
     'uiClass',
     'GhoSter_KbankPayments/js/view/payment/validator-handler'
-    //phpcs:ignore Squiz.Functions.MultiLineFunctionDeclaration.SpaceBeforeOpenParen
 ], function (
     $,
     Class,

diff --git a/view/frontend/web/js/model/installment.js b/view/frontend/web/js/model/installment.js
@@ -8,14 +8,16 @@ define([
 ], function (ko, _) {
     'use strict';
 
-    var proceedInstallmentData = function (data) {
-        let installmentData = {};
-        if (_.isObject(data)) {
-            installmentData['payment_term'] = data.hasOwnProperty('payment_term') ? data.payment_term : null;
-            installmentData['smartpay_id'] = data.hasOwnProperty('smartpay_id') ? data.smartpay_id : null;
-            installmentData['installment_title'] = data.hasOwnProperty('installment_title') ? data.installment_title : null;
-        }
-        return installmentData;
+    const proceedInstallmentData = function (data) {
+            let installmentData = {};
+
+            if (_.isObject(data)) {
+                installmentData['payment_term'] = data.hasOwnProperty('payment_term') ? data.payment_term : null;
+                installmentData['smartpay_id'] = data.hasOwnProperty('smartpay_id') ? data.smartpay_id : null;
+                installmentData['installment_title'] = data.hasOwnProperty('installment_title')
+                    ? data.installment_title : null;
+            }
+            return installmentData;
         },
         installmentData = proceedInstallmentData(window.checkoutConfig.quoteData),
         installmentInformation = ko.observable(installmentData),

diff --git a/view/frontend/web/js/view/payment/kbank-embedded/installment-renderer/default.js b/view/frontend/web/js/view/payment/kbank-embedded/installment-renderer/default.js
@@ -23,6 +23,7 @@ define([
 
                 if (installmentInformation) {
                     isSelected = installmentInformation.smartpay_id == this.installment().smartpay_id &&
+                        // eslint-disable-next-line max-len
                         installmentInformation.payment_term == this.installment().payment_term; //eslint-disable-line eqeqeq
                 }