Fixes Select dropdown implementation #8516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
dev-calendar
branch
from
a0cab6c to
92d7468
Compare
murilopereirame
force-pushed
the
fix-select-dropdown
branch
3 times, most recently
from
e873325 to
806cf94
Compare
murilopereirame
force-pushed
the
dev-calendar
branch
from
945ddb4 to
199b04d
Compare
This commit changes the Select to not use modals but instead a dive right before/after the dropdown trigger. This will increase the accessibility.
andrehgdias
force-pushed
the
fix-select-dropdown
branch
from
806cf94 to
6b451e0
Compare
andrehgdias
requested changes
Feb 13, 2025
murilopereirame
force-pushed
the
fix-select-dropdown
branch
from
8a3de40 to
fc4160d
Compare
andrehgdias
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the Select to not use modals but instead a dive right before/after the dropdown trigger. This will increase the accessibility.