Advanced repeat rules UI #8422
Open
Advanced repeat rules UI #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
c8134f0 to
040498f
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
30a7bb4 to
7aefc39
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
ffbc61b to
be4c63a
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
be4c63a to
e3da4ff
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
a0e43a2 to
4ff0a1d
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
3 times, most recently
from
cf65d58 to
7446664
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
10 times, most recently
from
d0e574b to
945ddb4
Compare
Base automatically changed from
8046-parse-advanced-repeat-rules
to
dev-calendar
February 13, 2025 04:19
Fixed the issue by allowing users to change the end date back to the same date as the initial date.
This commit adds a validation to mark short year/month dates as invalid. The only validation that we were doing was if Date(str) is valid, which is but not valid as intended to be. e.g. 00-07 would be interpreted as 07/1900 by JS Date instead of 07/2000 as expected.
Fixed Outlook event invite descriptions to preserve links after sanitization by applying the prepareCalendarDescription function
Add calendar info, color, name, and type, at event popup and event details (search and agenda view) Changes icon alignment to always align to the top, except when the data displayed fits in a single line, in this case it's centered.
This commits creates a new Calendar view, adding three day view and change the icon for Week View, making it easier to recognize both views.
This commit adds the options to select a default value for three days and week views to scroll to.
Co-authored-by: André Dias <[email protected]>
Co-authored-by: paw-hub <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Some rules aren't supported during event creation/editing. This commit adds an info banner warning about losing rules if user edits and event with unsupported rules. Co-authored-by: André Dias <[email protected]>
Co-authored-by: pas <[email protected]>
To have the SDK we must move the tests from unit to Instrumented Tests as unit tests aren't able to load our compiled SDK since the target mismatches (Unit tests require linux-x86-64). Mockito isn't able to mock final classes and instead of making all of them open, we can use dexmaker to proxy the classes and be able to fully mock final classes. This commit introduces dexmaker as a dependency and also overrides dexmaker mockito-core with a more updated one.
The way that we count events and occurrences changed with the implementation of the advanced repeat rules, given that, we've had to fix tests that relies on these counts. This commit address one corner case for weekly events expansion on SDK and fixes the tests on Swift.
murilopereirame
force-pushed
the
dev-calendar
branch
from
945ddb4 to
199b04d
Compare
Patrik-wav
force-pushed
the
8047-advanced-repeat-rules-ui
branch
from
cabb90a to
03f14a6
Compare
murilopereirame
requested changes
Feb 14, 2025
| const options: IntervalOption[] = [ | ||
| { | ||
| value: 0, | ||
| ariaValue: "same day", |
There was a problem hiding this comment.
Use the translation as aria value so screen readers can announce the correct value for the options
| const bydayRules = whenModel.advancedRules.filter((rule) => rule.ruleType == ByRule.BYDAY) | ||
| if (bydayRules.length == 1) { | ||
| const weekday: Weekday = Object.values(Weekday)[DateTime.fromJSDate(date).weekday - 1] | ||
| const regex = /^-?\d/g // Regex for extracting the first digit from interval |
There was a problem hiding this comment.
This will fail if the user has imported an event with a ByDay rule with +2TH (RFC allows this).
Either we take care of this during import, or we adapt this regex to support the + sign
| * we only specify what weekday of the month this event repeats on. (Ex.: BYDAY=2TH = Repeats on second THURSDAY of every month) | ||
| * In case weekdays.length() == 0 && interval == 0, no BYDAY Rule shall be written, as the event will repeat on the same DAY every month. | ||
| */ | ||
| private async createAdvancedRulesFromWeekdays(weekdays: Weekday[], interval?: number): Promise<AdvancedRepeatRule[]> { |
| @@ -486,24 +486,122 @@ export const createCustomEndTypeOptions = (): ReadonlyArray<RadioGroupOption<End | |||
| ] | |||
| } | |||
|
|
|||
| export const createRepeatRuleEndTypeValues = (): SelectorItemList<EndType> => { | |||
| export const weekdayToTranslation = (): Array<WeekdayToTranslation> => { | |||
There was a problem hiding this comment.
I think we can change it to an Array instead of a function. I'm not sure if it will break any rendering
| options: this.repetitionOptions, | ||
| noIcon: false, | ||
| expanded: false, | ||
| tabIndex: Number(TabIndex.Programmatic), |
There was a problem hiding this comment.
This takes the select component out of the element three, making it unreachable through tabbing
andrehgdias
force-pushed
the
dev-calendar
branch
from
50766e0 to
1361e3a
Compare
Selecting the time frame for rules will now render day/week/month/year correctly
Adds a new component to select the weekday were an event with weekly frequency should occur.
Fix undefined weekdays being written on AdvancedRules
When changing the date outside of the RepitionEditor, the advanced repeat rules would still use the old weekday. Now, when changing the date, it will also change the advanced repeat rules that have been configured
Drag and dropping an event inside the CalendarView would create inconsistencies within the advanced repeat rules.
The ARR on weekly events doesn't need to be handled, so this commit stops moving the ARR and also fixes an overflow on the main page of the event editor when the user has multiple days for a weekly repeating rule.
murilopereirame
force-pushed
the
8047-advanced-repeat-rules-ui
branch
from
d8149cd to
5c44da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8047