-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define code acesses for calendar and mail app #7240
Open
domesticated-raptor
wants to merge
33
commits into
dev-calendar
Choose a base branch
from
213-code-access
base: dev-calendar
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates the base android project to the Calendar App. It's the same as the mail app with less permission and without mailto and vcard handling Closes #7145 Co-authored-by: Murilo Pereira <[email protected]>
…ting time set to next half/full hour
Co-authored-by: @rih-tutao
Co-authored-by: @rih-tutao, @andrehgdias
Co-authored-by: rih <[email protected]>
Co-authored-by: rih <[email protected]>
Co-authored-by: @rih-tutao
Co-authored-by: @rih-tutao
This commit splits the settings files in: - Common for components and screen used by both apps; - Mail for settings related with the mail app; - Calendar for settings related with the calendar app. Co-authored-by: Murilo Pereira <[email protected]>
This commit fixes the Android project changing the gradle task used to build the Android app. Also fixes some import errors caused by the rebase. Co-authored-by: Murilo Pereira <[email protected]>
This commit prevents the redraw event from being fired when the sidebar is scrolled. The redraw isn't needed since we change the dom directly through target. Co-authored-by: André Dias <[email protected]> Fixes #7179
This commit adds the contacts permission page instead of the contacts import and sync when using the Calendar app. The permission is needed to suggest contacts when creating an event and inviting guests. Co-authored-by: André Dias <[email protected]> Fixes #7150
The calendar app doesn't have email or contacts, so it shouldn't handle search for these entities. This commit removes the Mail/Contact search and also fixes a bug related to calendar search skipping same day events. Co-authored-by: André Dias <[email protected]> Fixes #7155
…ter bugs Fixes calendar not selecting an event when the event ID is present in the URL. Also fixes the calendar selection that was throwing an error when moving back to All calendars Co-authored-by: André Dias <[email protected]>
This commit adds a check before changing the selected calendar in SearchView to prevent checking for Calendar values when selecting all calendars. This commit also fixes the item selection when page loads by subscribing to a stream and awaiting the list load before selecting a result. Co-authored-by: André Dias <[email protected]>
This commit modifies the Calendar App icon to use the new icon instead of using the same as the current mail app. Co-authored-by: André Dias <[email protected]> Closes #7148
Co-authored-by: @rih-tutao
This commit splits the settings files in: - Common for components and screen used by both apps; - Mail for settings related with the mail app; - Calendar for settings related with the calendar app. Co-authored-by: Murilo Pereira <[email protected]>
This commit fixes the Android project changing the gradle task used to build the Android app. Also fixes some import errors caused by the rebase. Co-authored-by: Murilo Pereira <[email protected]>
This commit adds the App field to push identifiers, letting the server know if the identifier belongs to Mail or Calendar app and send notifications correctly according to the app. Closes #7149
This commit fixes the Build scripts and missing imports from rebase.
I clarified with @charlag, in the ideal situation we would have a separate config for common and include that is a module (so common can only reference code inside common) but this setup would be fine for the initial release. |
24f5c3c
to
892b95f
Compare
0f0ba8c
to
4919979
Compare
9c34018
to
6e18a0c
Compare
565dc82
to
50e3012
Compare
457a019
to
0a748fc
Compare
b3f2e87
to
e52423c
Compare
e0a258e
to
498fb68
Compare
2f1265a
to
f1fd210
Compare
77f11c7
to
a79aa85
Compare
0867c19
to
1e62b32
Compare
03d4af3
to
bc0e451
Compare
30a33d9
to
d07a5cf
Compare
d07a5cf
to
167c8dd
Compare
167c8dd
to
dbbf01a
Compare
cacd38c
to
84f38f1
Compare
945ddb4
to
199b04d
Compare
50766e0
to
1361e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.