Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows Installation Methods #16

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

Gregory-K
Copy link
Contributor

@Gregory-K Gregory-K commented May 13, 2024

  • Provide .bat and .ps1 scripts
  • Both append yen ($env:userprofile\.yen\bin) to USER env PATH variable.

Resolves #15

@tusharsadhwani
Copy link
Owner

This seems great! It's just that I'm on vacation and not near a Windows machine just yet, so I can't properly test the scripts.

I'll merge it as soon as I can ensure this works as I expect it to.

@Gregory-K Gregory-K marked this pull request as ready for review May 19, 2024 15:38
@Gregory-K
Copy link
Contributor Author

Certainly! Take your time; vacations are a purposeful vacancy.

In the meanwhile, the addition of a small notice or the removal of curl -L yen.tushar.lol/install.bat | cmd in the README may prevent confusion or unforeseen issues, depending on the user's skill-set and backup options.
just a thought

@tusharsadhwani
Copy link
Owner

I'm home, I'll dust off my windows machine today, and get on this over the weekend.

Probably this and tusharsadhwani/packaged#15 I'll take care of.

install.ps1 Outdated Show resolved Hide resolved
@tusharsadhwani tusharsadhwani merged commit 26ee9cc into tusharsadhwani:main Jun 24, 2024
12 checks passed
@tusharsadhwani
Copy link
Owner

I'll be referencing this code for a long time, because i suck at bash and powershell. Thanks a ton!

@Gregory-K
Copy link
Contributor Author

You're welcome! I'm glad the code will be helpful to you.

@Gregory-K Gregory-K deleted the dev_win_install branch June 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows install.bat overwrites User's PATH
2 participants