-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to update game server from confconsole ui #14
Conversation
I haven't done any review of the code yet. But to test, just make these same changes on your local gameserver. I.e. something like this:
Then run Let me know how you go! :) |
Great work @Elyviere 😁 Thanks for your contribution. From a quick glance at this PR it looks good but we'll want a "proper" code review before merging. Hopefully we'll get that done ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, no notes. Thanks for the contribution!
Happy to have helped! |
Awesome. 😁 |
So I believe this is the solution to turnkeylinux/tracker#1990. No idea how to test it though, frankly it might not even compile, so I was hoping a maintainer would be able to test it out and see if it works as expected.
I'll add documentation once it's working, so please don't merge until it's tested and documentation has been updated.