Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update game server from confconsole ui #14

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

Elyviere
Copy link

@Elyviere Elyviere commented Oct 7, 2024

So I believe this is the solution to turnkeylinux/tracker#1990. No idea how to test it though, frankly it might not even compile, so I was hoping a maintainer would be able to test it out and see if it works as expected.

I'll add documentation once it's working, so please don't merge until it's tested and documentation has been updated.

@Elyviere Elyviere marked this pull request as draft October 7, 2024 15:58
@JedMeister
Copy link
Member

I haven't done any review of the code yet. But to test, just make these same changes on your local gameserver. I.e. something like this:

cd /usr/lib/confconsole/plugins.d/Game_Server/
mv update.py update_list.py
wget https://raw.githubusercontent.com/Elyviere/gameserver/refs/heads/master/overlay/usr/lib/confconsole/plugins.d/Game_Server/update_server.py

Then run confconsole, navigate through the menu and test your new option.

Let me know how you go! :)

@Elyviere Elyviere marked this pull request as ready for review October 8, 2024 04:50
@Elyviere
Copy link
Author

Elyviere commented Oct 8, 2024

That testing procedure was easier than expected, very nice.

Made some small fixes and updated the documentation. This is the new menu (not sure what's up with the colours/contrasts, but that's most likely just my console):

image

@Elyviere Elyviere changed the title UNTESTED: Add ability to update game server from confconsole ui Add ability to update game server from confconsole ui Oct 8, 2024
@JedMeister
Copy link
Member

Great work @Elyviere 😁 Thanks for your contribution.

From a quick glance at this PR it looks good but we'll want a "proper" code review before merging. Hopefully we'll get that done ASAP.

Copy link

@OnGle OnGle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, no notes. Thanks for the contribution!

@Elyviere
Copy link
Author

Happy to have helped!

@JedMeister
Copy link
Member

Awesome. 😁

@JedMeister JedMeister merged commit 5126e4f into turnkeylinux-apps:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants