Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John Hennerich #162

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

John Hennerich #162

wants to merge 13 commits into from

Conversation

jhennerich
Copy link

No description provided.

Copy link

@corneliusellen corneliusellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey John I just had a chance to go over your prework and things are looking very good! Great attention to detail on this.

You are officially turing ready! I added some comments to a few sections for areas to work on or adjustments to make before starting Mod 1. Keep up the hard work moving forward and let me know if you have any questions.

@@ -4,40 +4,66 @@

# Build a Bear

# define a method named build_a_bear passing in 5 arguments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better way to say this would be "declaring 5 parameters" (not arguments). Arguments are when you pass in the actual values. Parameters and arguments are 2 sides of the same coin, so to speak

(1..range).each do |i|

#condition if i divided by num_1 remainder (modulus) is 0 and i divided by num_2 remainder (modulus) is 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cleaner way to say this might be "if i divided by num_1 does not have a remainder, then do this"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants