-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tyler Ross #154
base: main
Are you sure you want to change the base?
Tyler Ross #154
Conversation
|
||
# - energy_level = 50 | ||
class SuperHero | ||
@@arch_nemesis = "The Syntax Error" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd advise making these instance variables - with only 1 @
and inside the initialize method.
# What skills do you need to continue to practice before starting Mod 1? | ||
|
||
#I dont have a good grasp of which topics I don't know until I am confronted by a new topic/issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's totally reasonable right now - this is brand new! And this is why you have instructors with a thoughtful curriculum - they will put challenges in front of you that you need to tackle, and provide feedback on how you're progressing.
@@ -4,40 +4,40 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really strong annotations! Good use of technical vocab, too
class GoodDog | ||
attr_accessor :name, :height, :weight | ||
|
||
def initialize(n, h, w) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll generally want to avoid using single letter variables in Ruby and most modern languages. The reason is readability for other devs, and it's simply not convention. In this case, I totally see where they came from and it makes sense enough, but definitely not a habit you want to get into.
@@ -1,22 +1,41 @@ | |||
## Section 4 Reflection | |||
|
|||
1. How different did your workflow feel this week, considering we asked you to follow the Pomodoro technique? | |||
It felt better in some respects, worse in others. 25 minutes is too small a time for me, as it can take me a while to figure out where I left off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good reflection! Totally ok to "up" that time to something that feels better for you. (BTW I am the same - set my timer for 50 then take a little longer of a break)
Hey there @Tross0208 - I have had a chance to review your work and you are Turing Ready! I added some comments to your work - check them out, but nothing you have to change or do to pass on the Mod 1. You mentioned not being sure on what you do/don't know, and needing to work on vocab. Yep, keep working a bit each day over the next couple weeks, but also know that that's kind of where you are supposed to be - you haven't even started full-time yet! All this great work you've done in Mod 0 will ensure that during those first very busy weeks of Mod 1, many things don't feel brand-new and super-scary. You have a foundation! You got this! |
@Tross0208 WAIT - I didn't check one thing. I don't see screenshots of your calendar under the |
HI Amy! Thanks for the comments, both compliments and criticisms. I see
that I am missing the Mod 1 calendar on my end as well. I will have that
updated by end of day today.
…On Tue, Nov 2, 2021 at 12:41 PM Amy Holt ***@***.***> wrote:
@Tross0208 <https://github.com/Tross0208> WAIT - I didn't check one
thing. I don't see screenshots of your calendar under the Time Management
Section of the finalprep section - am I missing that, or do you need to add
it? Let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALGPCKKB3JIUAP4I5ZBXS6LUKAWFXANCNFSM5HDB5BYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
No description provided.