Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tyler Ross #154

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Tyler Ross #154

wants to merge 7 commits into from

Conversation

Tross0208
Copy link

No description provided.


# - energy_level = 50
class SuperHero
@@arch_nemesis = "The Syntax Error"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advise making these instance variables - with only 1 @ and inside the initialize method.

# What skills do you need to continue to practice before starting Mod 1?

#I dont have a good grasp of which topics I don't know until I am confronted by a new topic/issue.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's totally reasonable right now - this is brand new! And this is why you have instructors with a thoughtful curriculum - they will put challenges in front of you that you need to tackle, and provide feedback on how you're progressing.

@@ -4,40 +4,40 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really strong annotations! Good use of technical vocab, too ☺️

class GoodDog
attr_accessor :name, :height, :weight

def initialize(n, h, w)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll generally want to avoid using single letter variables in Ruby and most modern languages. The reason is readability for other devs, and it's simply not convention. In this case, I totally see where they came from and it makes sense enough, but definitely not a habit you want to get into.

@@ -1,22 +1,41 @@
## Section 4 Reflection

1. How different did your workflow feel this week, considering we asked you to follow the Pomodoro technique?
It felt better in some respects, worse in others. 25 minutes is too small a time for me, as it can take me a while to figure out where I left off.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good reflection! Totally ok to "up" that time to something that feels better for you. (BTW I am the same - set my timer for 50 then take a little longer of a break)

@ameseee
Copy link
Collaborator

ameseee commented Nov 2, 2021

Hey there @Tross0208 - I have had a chance to review your work and you are Turing Ready! I added some comments to your work - check them out, but nothing you have to change or do to pass on the Mod 1. You mentioned not being sure on what you do/don't know, and needing to work on vocab. Yep, keep working a bit each day over the next couple weeks, but also know that that's kind of where you are supposed to be - you haven't even started full-time yet! All this great work you've done in Mod 0 will ensure that during those first very busy weeks of Mod 1, many things don't feel brand-new and super-scary. You have a foundation! You got this!

@ameseee
Copy link
Collaborator

ameseee commented Nov 2, 2021

@Tross0208 WAIT - I didn't check one thing. I don't see screenshots of your calendar under the Time Management Section of the finalprep section - am I missing that, or do you need to add it? Let me know.

@Tross0208
Copy link
Author

Tross0208 commented Nov 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants