-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximilian Wagner #151
base: main
Are you sure you want to change the base?
Maximilian Wagner #151
Conversation
def initialize(protein, base, toppings) | ||
@protein = protein | ||
@base = base | ||
@toppings = toppings | ||
end | ||
|
||
def add_topping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give you a nudge for this one that may also help with the change_protein
method -
Currently, the add_topping
method adds more of the original topping. Could you rework it so the user can choose a NEW topping to add to their burrito? How can information be added dynamically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or would we be looking to change the attribute reader to accessor? Then do something like
def change_protein(protein)
@protein = protein
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would work, and the same logic could be applied to the add_topping.
Hey there @MWagner3 - your work so far looks good, I left a couple comments I'd like you to read through and update as appropriate! From what I can see, I don't believe you've completed (or at least pushed up) the finalprep section of the prework - specifically the technical work. The boxes were checked but the files were untouched. Is that correct? |
Hey Amy! In the morning I will take a look at your comments and see what the issue was in the final prep section. I thought I had submitted everything so I will go back and take a look. Thanks |
Decided just to take a quick look now and just pushed the last portion through. I am not sure how I missed that, yikes. |
Looks good Max, I've marked you as Turing Ready! Good luck in Mod 1 - you've got this. |
Here is the Mod 1 prework