Add table detailed billing report #129
Conversation
| // Fallbacks for TpIndex and TpTimestamp | ||
| if typehelpers.SafeString(row.LinkedAccountId) != "" { | ||
| row.TpIndex = *row.LinkedAccountId | ||
| } else if typehelpers.SafeString(row.PayerAccountId) != "" { |
There was a problem hiding this comment.
Please add a comment on when we would use the payer account ID instead (probably when the line is for the payer itself).
There was a problem hiding this comment.
Also, is there a way to tell if a line item is for the bill payer vs. linked account? For instance, if the line is for a linked account, but someone removes the SubAccountId value accidentally, are there other ways to tell if a line is for a linked vs. payer account?
There was a problem hiding this comment.
If the cost is associated with the billing account, the record_type column will contain the value PayerLineItem.
There was a problem hiding this comment.
In that case, for tp_index, could we:
- For linked accounts, use
LinkedAccountId - For payer accounts, use
PayerAccountId
In both cases, we'd have no fallback (Tailpipe should error if either of those fields are missing for the respective account type)
tables/detailed_billing_report/detailed_billing_report_table.go
Outdated
Show resolved
Hide resolved
Co-authored-by: cbruno10 <[email protected]>
Example query results
Results