-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table aws_keyspaces_table Closes #2264 #2271
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI please take a look at the review comments. Thanks!!
aws/table_aws_keyspaces_table.go
Outdated
func tableAwsKeyspacesTable(ctx context.Context) *plugin.Table { | ||
return &plugin.Table{ | ||
Name: "aws_keyspaces_table", | ||
Description: "AWS Keyspace Table", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description: "AWS Keyspace Table", | |
Description: "AWS Keyspaces Table", |
List: &plugin.ListConfig{ | ||
Hydrate: listKeyspacesTables, | ||
KeyColumns: plugin.KeyColumnSlice{ | ||
{Name: "keyspace_name", Require: plugin.Required}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use the ParentHydrate config over here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can use it. However, we currently don't have a table that provides the keyspace name. We'll need to add a separate table for that first, and then we can proceed.
@ParthaI I think @Priyanka-Chatterjee-2000 would need this table for the Compliance benchmark, wherein passing a I would suggest adding the Parent table to eliminate the need of the required qual. Thanks!! |
I will add the parent table 👍 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Integration test logs
Logs
Example query results
Results