linting

turbot · Dec 4, 2024 · cac2412 · cac2412
1 parent 4386b80
commit cac2412
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/connection/connection_test.go b/connection/connection_test.go
@@ -2065,7 +2065,8 @@ func TestMysqlConnectionGetConnectionString(t *testing.T) {
 			}
 			// call validate to initialise the default values
 			_ = c.Validate()
-			assert.Equalf(t, tt.want, c.GetConnectionString(), "GetConnectionString()")
+			cs, _ := c.GetConnectionString()
+			assert.Equalf(t, tt.want, cs, "GetConnectionString()")
 		})
 	}
 }
@@ -2656,7 +2657,8 @@ func TestPostgresConnectionGetConnectionString(t *testing.T) {
 			}
 			// call validate to initialise the default values
 			_ = c.Validate()
-			assert.Equalf(t, tt.want, c.GetConnectionString(), "GetConnectionString()")
+			cs, _ := c.GetConnectionString()
+			assert.Equalf(t, tt.want, cs, "GetConnectionString()")
 		})
 	}
 }
@@ -3378,7 +3380,8 @@ func TestSteampipeConnectionGetConnectionString(t *testing.T) {
 				Password: tt.fields.password,
 				SslMode:  tt.fields.sslMode,
 			}
-			assert.Equalf(t, tt.want, c.GetConnectionString(), "GetConnectionString()")
+			cs, _ := c.GetConnectionString()
+			assert.Equalf(t, tt.want, cs, "GetConnectionString()")
 		})
 	}
 }

diff --git a/steampipeconfig/pipes_workspace.go b/steampipeconfig/pipes_workspace.go
@@ -18,7 +18,7 @@ func IsPipesWorkspaceConnectionString(csp connection.ConnectionStringProvider) b
 	connectionString, err := csp.GetConnectionString()
 	if err != nil {
 		// unexpected - we do not expect errors from non dynamic connection strings
-		slog.Warn("unexpected error getting connection string from non-dynamic %T: %v", csp, err)
+		slog.Warn("unexpected error getting connection string from non-dynamic provider", "type", csp, "error", err)
 		return false
 	}