Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite NOpenCL.Buffer as generic type Buffer<T> #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jul 9, 2017

Rename NOpenCL.Buffer to generic type Buffer<T>.

Indirectly resolves the naming collision with System.Buffer identified by @SunsetQuest in 74bc9ba.

@codecov
Copy link

codecov bot commented Jul 9, 2017

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   37.33%   37.33%           
=======================================
  Files          55       55           
  Lines        2341     2341           
  Branches      385      385           
=======================================
  Hits          874      874           
  Misses       1318     1318           
  Partials      149      149
Impacted Files Coverage Δ
NOpenCL/CommandQueue.cs 27.33% <ø> (ø) ⬆️
NOpenCL/KernelArgument.cs 37.93% <ø> (ø) ⬆️
NOpenCL/Image.cs 0% <ø> (ø) ⬆️
NOpenCL/Buffer`1.cs 16.66% <0%> (ø)
NOpenCL.Test/TestBuffers.cs 100% <100%> (ø) ⬆️
NOpenCL.Test/Intel/Optimization.cs 77.85% <100%> (ø) ⬆️
NOpenCL.Test/NVidia/VectorAdd.cs 82.4% <100%> (ø) ⬆️
NOpenCL/Context.cs 30.76% <100%> (ø) ⬆️
NOpenCL.Test/NVidia/Bandwidth.cs 57.97% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5fe62...fbbb00f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant