Merge pull request #28 from sharwell/fix-13

Fix navigation to members located in a different project
tunnelvisionlabs · Sep 7, 2016 · cce92aa · cce92aa
2 parents 128f56d + 84e6dd8
commit cce92aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Tvl.VisualStudio.InheritanceMargin.CSharp/CSharpInheritanceAnalyzer.cs b/Tvl.VisualStudio.InheritanceMargin.CSharp/CSharpInheritanceAnalyzer.cs
@@ -440,7 +440,7 @@ protected override void ReParseImpl()
                         members.AddRange(implementingMethods);
                         members.AddRange(overridingMethods);
 
-                        var targets = members.Select(i => new MemberTarget(textContainer, i, project, solution));
+                        var targets = members.Select(i => new MemberTarget(textContainer, i, solution));
                         tags.Add(new TagSpan<IInheritanceTag>(span, _tagFactory.CreateTag(tag, builder.ToString().TrimEnd(), targets)));
                     }
                 }

diff --git a/Tvl.VisualStudio.InheritanceMargin.CSharp/MemberTarget.cs b/Tvl.VisualStudio.InheritanceMargin.CSharp/MemberTarget.cs
@@ -10,14 +10,12 @@ internal sealed class MemberTarget : IInheritanceTarget
     {
         private readonly SourceTextContainer _textContainer;
         private readonly ISymbol _memberIdentifier;
-        private readonly Project _project;
         private readonly Solution _solution;
 
-        public MemberTarget(SourceTextContainer textContainer, ISymbol memberIdentifier, Project project, Solution solution)
+        public MemberTarget(SourceTextContainer textContainer, ISymbol memberIdentifier, Solution solution)
         {
             _textContainer = textContainer;
             _memberIdentifier = memberIdentifier;
-            _project = project;
             _solution = solution;
         }
 
@@ -33,7 +31,7 @@ public string DisplayName
         /// <inheritdoc/>
         public void NavigateTo()
         {
-            CSharpInheritanceAnalyzer.NavigateToSymbol(_textContainer, _memberIdentifier, _project);
+            CSharpInheritanceAnalyzer.NavigateToSymbol(_textContainer, _memberIdentifier, _solution.GetProject(_memberIdentifier.ContainingAssembly));
         }
     }
 }