Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] [Backend] oEmbed endpoint standardization & Wikonnect Open Graph protocol integration #640

Merged
merged 5 commits into from
Mar 22, 2021
Merged

[FEATURE] [Backend] oEmbed endpoint standardization & Wikonnect Open Graph protocol integration #640

merged 5 commits into from
Mar 22, 2021

Conversation

0xMurage
Copy link
Collaborator

Partial #634

Change Log

  • Adds Open Graph meta tags on all public routes
  • Ensures the embed API endpoint response conforms with oEmbed format.
  • Adds support for oEmbed xml response
  • Adds oEmbed content meta tags on each chapter page

@0xMurage 0xMurage self-assigned this Mar 19, 2021
@proverbial-ninja proverbial-ninja merged commit 5985ba6 into master Mar 22, 2021
@proverbial-ninja proverbial-ninja deleted the oembed-submission branch March 22, 2021 06:01
0xMurage added a commit that referenced this pull request Mar 30, 2021
@0xMurage @mosesokemwa @brianmarete
Merge H5P editor branch with Staging (#668)
a29aba8 
* [FEATURE] [FRONTEND] Update H5P editor on-init event hook (#631)

* change editor-on-init to use element polling

* #fix Public folder on production should be mounted to avoid content deletion on re-deployment

Co-authored-by: Moses Okemwa <[email protected]>

* [FEATURE] [Backend] oEmbed endpoint standardization & Wikonnect Open Graph protocol integration (#640)

* Add extra global properties

* standardize oEmbed response format & added XML support

Signed-off-by: mimidots <[email protected]>

* Inject oEmbed & Open Graph meta tags into page headers

* bug fix #comment component not found during tests

* Feature/wik 63 updating single chapter page to match design (#647)

* Add assets

* Delete assests

* Add assets

* Change chapter comments api response

* Update single chapter creator and description sections

* Add ember inflector package for pluralizing words

* Add reply-section component

* Update comment model to have replies

* Add getter for showing number of comments

* Add reply component to comment component

* Update styles to match designs

* Add username above comment form

* ignoring data folder for postgres image mount

Signed-off-by: mosesokemwa <[email protected]>

* Lint fixes

* Add Share component to display
social media sharing options on single chapter page

* Add assets

* Delete assests

* Add assets

* Change chapter comments api response

* Update single chapter creator and description sections

* Add ember inflector package for pluralizing words

* Add reply-section component

* Update comment model to have replies

* Add getter for showing number of comments

* Add reply component to comment component

* Update styles to match designs

* Add username above comment form

* Lint fixes

* Add Share component to display
social media sharing options on single chapter page

* ignoring data folder for postgres image mount

Signed-off-by: mosesokemwa <[email protected]>

* alter comments replies relationship

Signed-off-by: mosesokemwa <[email protected]>

* automated migration run after deployment

Signed-off-by: mosesokemwa <[email protected]>

* Testing replies

* Fix comments and replies section

* Fix breaking circle ci tests

* Fix reply cypress tests

* Fix failing cypress tests on Circle CI

Co-authored-by: mosesokemwa <[email protected]>

* [BUG] Teach module content preview page broken if chapter has tags #652 (#655)

* fix #content preview page broken if chapter has tags

Signed-off-by: mimidotsuser <[email protected]>

* fix failing Cypress test

Signed-off-by: mimidotsuser <[email protected]>

* fix failing Cypress test

Signed-off-by: mimidotsuser <[email protected]>

* fixes failing tests and removes any test hack fixes

Signed-off-by: mimidotsuser <[email protected]>

* remove awesome homepage reaction tests hacks. Boring is sure bet.

Signed-off-by: mimidotsuser <[email protected]>

* fix failing homepage reaction tests

Signed-off-by: mimidotsuser <[email protected]>

* rollback last tests

Signed-off-by: mimidotsuser <[email protected]>

* Hot fix: Chapter & comments author details not displayed correctly  (#657)

* align single chapter action icons

Signed-off-by: mimidotsuser <[email protected]>

* fix issue with uploading & fetching user profile picture locally

Signed-off-by: mimidotsuser <[email protected]>

* added name attribute to a user model

Signed-off-by: mimidotsuser <[email protected]>

* fix #chapter not returning user profile image and name details

Signed-off-by: mimidotsuser <[email protected]>

* fixed chapter author details shown as private at homepage & single chapter page

Signed-off-by: mimidotsuser <[email protected]>

* avoid re-fetching chapter author profile images if previously done

Signed-off-by: mimidotsuser <[email protected]>

* fix #user GET all routes not returning any users' info

Signed-off-by: mimidotsuser <[email protected]>

* correctly display comment author name and profile picture (if profile is not private)

Signed-off-by: mimidotsuser <[email protected]>

* fix #user should not be able to submit empty comment or reply

Signed-off-by: mimidotsuser <[email protected]>

* fix #fallback username not found in user's model virtual property

Signed-off-by: mimidotsuser <[email protected]>

* fix #single chapter author object details mismatch

Signed-off-by: mimidotsuser <[email protected]>

* fix failing tests.

Signed-off-by: mimidotsuser <[email protected]>

* about page should link to wikonnect.org & single chapter page title should indicate the current chapter title

Signed-off-by: mimidotsuser <[email protected]>

* Fix typos and add links to developers and designers (#660)

* Fix typos and add links to developers and designers

* Fix typos and add links to developers and designers

* Capitalize Swag

Signed-off-by: mimidotsuser <[email protected]>

Co-authored-by: mimidotsuser <[email protected]>

* hotfix/chapter-creator-images (#661)

* Fix/translating strings (#662)

* fix pluralization of number of comments

* Add lint rule to ensure no bare strings

* Add translations for home page

* Add translations to single chapter page

* Add translations for login page

* Remove ember inflector package

* Add translations to signup form

* Add translations for teach preview page

* Add translations to user profile

* Add missing translations to components

* Add missing translations to miscelaneous templates

* Fix failing comment cypress test

* Update README with link to Nathan's github

* H5p editor configuration file not found fix (#663)

* use getters while retrieving adapter headers since session has tracked properties

Signed-off-by: mimidotsuser <[email protected]>

* Fix #H5P config file not found

Signed-off-by: mimidotsuser <[email protected]>

* Added H5P editor two base endpoints documentation

Signed-off-by: mimidotsuser <[email protected]>

* fix H5P editor static content not loading (#664)

Signed-off-by: mimidotsuser <[email protected]>

* PM2 ecosystem config updates (#665)

Signed-off-by: mimidotsuser <[email protected]>

Co-authored-by: Moses Okemwa <[email protected]>
Co-authored-by: Brian Marete <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proverbial-ninja proverbial-ninja proverbial-ninja approved these changes

Assignees

@0xMurage 0xMurage

Labels
phase:1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xMurage @proverbial-ninja