Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yacs.CfgNode instead of argparse.Namespace #27

Closed
wants to merge 13 commits into from
Closed

Conversation

gerkone
Copy link
Member

@gerkone gerkone commented Feb 15, 2024

No description provided.

@arturtoshev arturtoshev marked this pull request as ready for review February 16, 2024 11:00
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (3611d56) 69.4% compared to head (776397d) 65.3%.
Report is 5 commits behind head on main.

Files Patch % Lines
lagrangebench/runner.py 0.0% 119 Missing ⚠️
lagrangebench/train/trainer.py 15.0% 17 Missing ⚠️
lagrangebench/config.py 87.8% 12 Missing ⚠️
lagrangebench/evaluate/rollout.py 50.0% 3 Missing ⚠️
lagrangebench/models/gns.py 25.0% 3 Missing ⚠️
lagrangebench/models/painn.py 80.0% 1 Missing ⚠️
lagrangebench/utils.py 75.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #27     +/-   ##
=======================================
- Coverage   69.4%   65.3%   -4.1%     
=======================================
  Files         25      26      +1     
  Lines       1661    1866    +205     
=======================================
+ Hits        1154    1220     +66     
- Misses       507     646    +139     
Flag Coverage Δ
unittests 65.3% <45.0%> (-4.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerkone
Copy link
Member Author

gerkone commented Feb 23, 2024

Moved to #28 in favor of OmegaConf for multiple reasons:

  • more flexibility and simplicity in OmegaConf structures
  • integration with hyperparameter search frameworks
  • ease of use for library version users

@gerkone gerkone closed this Feb 23, 2024
@arturtoshev arturtoshev deleted the new-configs branch June 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants