Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout extrapolation steps fix #25

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Rollout extrapolation steps fix #25

merged 2 commits into from
Feb 14, 2024

Conversation

gerkone
Copy link
Member

@gerkone gerkone commented Feb 12, 2024

No description provided.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d0e5133) 69.5% compared to head (b03cd06) 69.4%.

Files Patch % Lines
lagrangebench/evaluate/rollout.py 20.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #25     +/-   ##
=======================================
- Coverage   69.5%   69.4%   -0.1%     
=======================================
  Files         25      25             
  Lines       1660    1661      +1     
=======================================
  Hits        1154    1154             
- Misses       506     507      +1     
Flag Coverage Δ
unittests 69.4% <20.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arturtoshev
Copy link
Member

Looks good!

@arturtoshev arturtoshev merged commit 3611d56 into main Feb 14, 2024
5 of 6 checks passed
@arturtoshev arturtoshev deleted the extrap_steps branch June 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants