Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #21

Merged
merged 17 commits into from
Jan 8, 2024
Merged

Unit tests #21

merged 17 commits into from
Jan 8, 2024

Conversation

arturtoshev
Copy link
Member

Addition of a few new unit tests:

  • case_setup including preprocessing (allocate / update), neighbors search, and integration loop
  • push-forward utils
  • rollout loop. Defines a "cheating" model, which returns the target accelerations, and results in perfectly reproducing the trajectory up to numerical precision during the integration. A new dummy dataset of 3 Lennard-Jones particles (<1MB) is added to this unit test.

Comment on lines +28 to +29
args: [ --fix ]
- id: ruff-format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not automatically hard fix things as a default

Comment on lines 5 to +7
authors = [
"Artur Toshev, Gianluca Galletti <[email protected]>"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this works out on pypi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@gerkone gerkone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the tests. Looks good to me.

Copy link

codecov bot commented Jan 5, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@arturtoshev arturtoshev merged commit af8d7cd into main Jan 8, 2024
5 checks passed
@arturtoshev arturtoshev deleted the unit_tests branch January 8, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants