Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working delta-sph and fix usage of "h_factor" #19

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

JonasErbesdobler
Copy link
Collaborator

-implementation of delta-SPH for the current main branch
-kernel.h_factor can now be utilized

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.25275% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.6%. Comparing base (0561f51) to head (324199b).

Files Patch % Lines
jax_sph/solver.py 45.9% 47 Missing ⚠️
jax_sph/case_setup.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #19     +/-   ##
=======================================
- Coverage   66.4%   65.6%   -0.9%     
=======================================
  Files         11      11             
  Lines       1353    1420     +67     
=======================================
+ Hits         899     932     +33     
- Misses       454     488     +34     
Flag Coverage Δ
unittests 65.6% <47.2%> (-0.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jax_sph/solver.py Outdated Show resolved Hide resolved
jax_sph/solver.py Outdated Show resolved Hide resolved
jax_sph/solver.py Outdated Show resolved Hide resolved
jax_sph/solver.py Outdated Show resolved Hide resolved
Copy link
Member

@arturtoshev arturtoshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@arturtoshev arturtoshev merged commit 2623413 into main Jul 18, 2024
2 checks passed
@arturtoshev arturtoshev deleted the delta-sph branch July 18, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants