update codecov params

.codecov.yml

@@ -1,12 +1,12 @@
-coverage:  # TODO: increase required values once proper tests are implemented
-  range: 2..3  # red color under 50%, yellow at 50%..70%, green over 70%
+coverage:
+  range: 50..60  # red color under 50%, yellow at 50%..60%, green over 60%
   precision: 1
   status:
     project:
       default:
-        target: 2%  # coverage success only above X%. Later to be changed to e.g. 60%
+        target: 60%  # coverage success only above X%
         threshold: 5%  # allow the coverage to drop by X% and being a success
     patch:
       default:
-        target: 5%  # later to be changed to e.g. 50%
+        target: 50%
         threshold: 5%

.github/workflows/tests.yml

@@ -35,7 +35,7 @@ jobs:
       run: |
         .venv/bin/pytest --cov-report=xml
     - name: Upload coverage report to Codecov
-      uses: codecov/codecov-action@v3
+      uses: codecov/codecov-action@v4
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         file: ./coverage.xml

jax_sph/simulate.py

@@ -86,7 +86,7 @@ def simulate(cfg: DictConfig):
     # Instantiate advance function for our use case
     advance = si_euler(cfg.solver.tvf, forward, shift_fn, bc_fn)
 
-    advance = advance if cfg.no_jit else jit(advance)  # TODO: is this even needed?
+    advance = advance if cfg.no_jit else jit(advance)
 
     print("#" * 79, "\nStarting a JAX-SPH run with the following configs:")
     print(OmegaConf.to_yaml(cfg))

notebooks/iclr24_inverse.ipynb

@@ -193,7 +193,7 @@
     "\n",
     "    # Instantiate advance function for our use case\n",
     "    advance = si_euler(cfg.solver.tvf, forward, shift_fn, bc_fn)\n",
-    "    advance = advance if cfg.no_jit else jit(advance)  # TODO: is this even needed?\n",
+    "    advance = advance if cfg.no_jit else jit(advance)\n",
     "\n",
     "    # compile kernel and initialize accelerations\n",
     "    _state, _neighbors = advance(0.0, optim_init_state, neighbors)\n",

pyproject.toml

@@ -58,7 +58,7 @@ select = [
 
 [tool.pytest.ini_options]
 testpaths = "tests/"
-addopts = "--cov=jax_sph --cov-fail-under=1"  # TODO: increase later e.g. to 50
+addopts = "--cov=jax_sph --cov-fail-under=50"
 filterwarnings = [
     # ignore all deprecation warnings except from jax-sph
     "ignore::DeprecationWarning:^(?!.*jax_sph).*"