New Decoding Algorithm #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recently ran into a strange bug in the ETISS decoder, which I was just able to fix by applying this PR. LGTM, at least from my side. |
|
As per discussion today, we should aim to integrate this PR quickly. @togulcan can you please add a bit of documentation a) in the source code, describing what happens, and b) in the top-level README providing a more conceptual overview of the algorithm? |
PhilippvK
requested changes
Jul 18, 2023
|
already fixed, thanks for finding it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous decoding algorithm had a severe bug. Please see #111.
Here is the new one.