Keep whitespaces at the extremities of codeblocks #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that codeblocks tokens are correctly parsed, there is no need anymore for parsing its content and then extracting its plaintext version. This allows to save some computation and to preserve the whitespaces at the beginning and end of a codeblock. Previously, messages containing only an empty codeblock where not displayed. Now the text of the codeblock defaults to '\n' so the message is always displayed.
|
Looks a bit sus since code blocks can contain HTML 🤔 |
I'll check again, as I don't exactly remember why I made this commit like this (that's why I marked this PR as draft). But from my limited testing, HTML in code block seems to be handled by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old commit I forgot to send, as a follow-up to #387