-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mautrix go #393
base: master
Are you sure you want to change the base?
Upgrade mautrix go #393
Conversation
So the problems indeed come from mautrix/go@d2005e5. My second commit ce4e867 only fixes one of the bugs it introduced in gomuks, as it relies on the I tried to revert the @tulir: is this breaking change expected or should we try to fix it in mautrix ? Maybe we can keep a pointer and allocate it in mautrix while unmarshalling. But it may defeat the purpose of changing it into a pointer (I am not really sure what was the purpose of changing it into a pointer). |
ce4e867
to
80135d5
Compare
Just upgraded mautrix from v0.12.2 to v0.12.4. I will keep this version for a few days to see if new problems arise. |
Hmm this is not so good. I started to get some "unable to decrypt" errors recently and I suspect it comes from this change. I noticed in the gomuks debug log the following errors:
And quite a lot of "database is locked" errors:
|
80135d5
to
a524c7b
Compare
Only needed to use NewContext instead of make
Hi @tulir, I rebased this branch over master and updated to mautrix v0.14.0 (I will maybe see later for the latest versions). I think the first error described in #393 (comment) came from alternating between v0.11 and v0.12 mautrix versions (which was a bad idea). I don't really know for the second one, but it also might be related. I will keep using this branch for some time to see if these errors come back or if new one arise. |
Mautrix go has not been updated since a long time. As I wanted to add a feature to the library I noticed that there were quite a lot of breaking changes. So I started by updated mautrix.
I am not sure about the second commit. I added it because after the update, gomuks panicked while loading new messages without relations.
I don't know if this is normal, but it seems
event.Unsigned.Relations
can now benil
, while gomuks expected this variable to always be initialised.If I understand correctly, this value was previously always populated by
ParsedRaw()
. This new behaviour may be related to this change: mautrix/go@d2005e5