Add caching to static blocks while loading segments #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillschallau
requested changes
May 13, 2024
There was a problem hiding this comment.
Please rewrite the code to not include the not-null assertion operator (!!). Consider getOrPut() or similar functions on Maps.
dominikmaeckel
force-pushed
the
static-blocks-caching
branch
from
1f8f7f3
to
521db9b
Compare
dominikmaeckel
force-pushed
the
static-blocks-caching
branch
from
cc0c0d5
to
ed665c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.