Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify blobを使って保存 #1443

Merged
merged 6 commits into from
Mar 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
netlify blobを使って保存
tubone24 committed Mar 16, 2024
commit 2994e84bc6dfc69e66859b7efd0359316b0bbc52
8 changes: 6 additions & 2 deletions src/components/SEO/index.spec.tsx
Original file line number Diff line number Diff line change
@@ -84,7 +84,9 @@ describe("SEO", () => {
expect(twitterCreator).toBe("@meitante1conan");
expect(twitterTitle).toBe("testTitle");
expect(twitterDescription).toBe("testDescription");
expect(twitterImage).toBe("https://example.com/test.png");
expect(twitterImage).toBe(
"https://blog.tubone-project24.xyz/ogp.png?title=testTitle"
);
});
it("should render metadata (not article)", () => {
render(
@@ -166,6 +168,8 @@ describe("SEO", () => {
expect(twitterTitle).toBe("testTitle");
expect(twitterCreator).toBe("@meitante1conan");
expect(twitterDescription).toBe("testDescription");
expect(twitterImage).toBe("https://example.com/test.png");
expect(twitterImage).toBe(
"https://blog.tubone-project24.xyz/ogp.png?title=testTitle"
);
});
});
5 changes: 4 additions & 1 deletion src/components/SEO/index.tsx
Original file line number Diff line number Diff line change
@@ -98,6 +98,9 @@ const SEO = ({
isPost,
tag,
}: Props) => {
const ogpImageLink = `https://blog.tubone-project24.xyz/ogp.png?title=${encodeURI(
title
)}`;
return (
<Helmet>
<title>{title}</title>
@@ -139,7 +142,7 @@ const SEO = ({
<meta name="twitter:creator" content="@meitante1conan" />
<meta name="twitter:title" content={title} />
<meta name="twitter:description" content={description} />
<meta name="twitter:image" content={image} />
<meta name="twitter:image" content={ogpImageLink} />
</Helmet>
);
};