This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
Fix flaky test testParamsByNameUnmatchedMessage() #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
The PR proposes a fix for the following tests -
net.ttddyy.dsproxy.asserts.hamcrest.ParameterHolderAssertionsTest#testParamsByNameUnmatchedMessage
Build Project
Problem
This flakiness was identified by the nondex tool created by the researchers of UIUC. The above eight tests fail when run on the nondex tool.
This test uses a map with keys
foo
andbar
and is being asserted that the order must be with keysbar
andfoo
. Simply changing the order of insertion of the map values will not solve this since the map still does not maintain order of insertion and there are possibilities this can fail again in the same waydatasource-assert/src/test/java/net/ttddyy/dsproxy/asserts/hamcrest/ParameterHolderAssertionsTest.java
Lines 113 to 126 in 2cf1ad3
Fix:
The proposed fix is to use a
LinkedHashMap
instead of a map since it will maintain the order of insertion