Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new Gr1km-v2 1km Greenland model from ESR #59

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Conversation

tsutterley
Copy link
Owner

feat: added 3413 projection for new 1km Greenland model from ESR

fix: tidal currents for bilinear interpolation to address part of #57

fix: add warning for tide models being entered as string to address #58

docs: update documentation for new model

feat: added 3413 projection for new 1km Greenland model from ESR

fix: tidal currents for bilinear interpolation to address part of #57

fix: add warning for tide models being entered as string to address #58

docs: update documentation for new model
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #59 (cbe73d8) into main (1ad610e) will decrease coverage by 0.36%.
The diff coverage is 35.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   76.46%   76.09%   -0.37%     
==========================================
  Files          47       47              
  Lines        4741     4778      +37     
  Branches      474      480       +6     
==========================================
+ Hits         3625     3636      +11     
- Misses        944      965      +21     
- Partials      172      177       +5     
Flag Coverage Δ
unittests 76.09% <35.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyTMD/compute_tide_corrections.py 31.14% <20.00%> (-0.83%) ⬇️
pyTMD/convert_ll_xy.py 80.51% <20.00%> (-9.04%) ⬇️
pyTMD/read_FES_model.py 43.54% <25.00%> (-0.62%) ⬇️
pyTMD/read_GOT_model.py 95.04% <25.00%> (-2.40%) ⬇️
pyTMD/read_netcdf_model.py 54.97% <25.00%> (-0.65%) ⬇️
pyTMD/read_tide_model.py 39.54% <85.71%> (+0.69%) ⬆️
test/test_download_and_read.py 99.73% <100.00%> (ø)
pyTMD/utilities.py 71.53% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf41ca...cbe73d8. Read the comment docs.

fix: check for nan points when reading OTIS models
docs: add notes to interpolation with warnings
@tsutterley tsutterley changed the title feat: added new Arc1km-v2 1km Greenland model from ESR feat: added new Gr1km-v2 1km Greenland model from ESR Jun 14, 2021
@tsutterley tsutterley merged commit b386a33 into main Jun 15, 2021
@tsutterley tsutterley deleted the arc1km branch June 15, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant