Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include inference of eps2 and eta2 when predicting from GOT models #319

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

tsutterley
Copy link
Owner

feat: add attribute for minor constituents to model object
feat: allow inferring only specific minor constituents
feat: allow searching over iterable glob strings in definition files for #318

feat: add attribute for minor constituents to model object
feat: allow inferring only specific minor constituents
feat: allow searching over iterable glob strings in definition files for #318
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 74.54545% with 42 lines in your changes missing coverage. Please review.

Project coverage is 69.35%. Comparing base (3d1d88a) to head (f39525b).
Report is 1 commits behind head on main.

Files Patch % Lines
pyTMD/io/model.py 50.58% 37 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   69.17%   69.35%   +0.18%     
==========================================
  Files          39       39              
  Lines        9365    10566    +1201     
  Branches     1322     1473     +151     
==========================================
+ Hits         6478     7328     +850     
- Misses       2467     2762     +295     
- Partials      420      476      +56     
Flag Coverage Δ
unittests 69.35% <74.54%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsutterley tsutterley merged commit 366dccb into main Aug 9, 2024
2 checks passed
@tsutterley tsutterley deleted the dev branch August 9, 2024 12:20
tsutterley added a commit that referenced this pull request Aug 9, 2024
…els (#319)

* feat: add attribute for minor constituents to model object
* feat: allow inferring only specific minor constituents
* feat: allow searching over iterable glob strings in definition files for #318
* feat: add option to auto-detect definition file format for #318
* feat: add back nodal arguments from PERTH3 for backwards compatibility
* chore: trim trim trailing whitespace
* docs: add GOT5.5 to getting started
tsutterley added a commit that referenced this pull request Aug 9, 2024
* feat: add attribute for minor constituents to model object
* feat: allow inferring only specific minor constituents
* feat: allow searching over iterable glob strings in definition files for #318
* feat: add option to auto-detect definition file format for #318
* feat: add back nodal arguments from PERTH3 for backwards compatibility
* chore: trim trim trailing whitespace
* docs: add GOT5.5 to getting started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant