Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ESR netCDF4 formats to list of model types #101

Merged
merged 14 commits into from
Jul 1, 2022
Merged

Conversation

tsutterley
Copy link
Owner

@tsutterley tsutterley commented May 16, 2022

refactor: changed keyword arguments to camel case to partially address #100

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #101 (947626a) into main (01b5498) will decrease coverage by 1.14%.
The diff coverage is 44.12%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   67.57%   66.43%   -1.15%     
==========================================
  Files          45       45              
  Lines        5996     6223     +227     
  Branches      599      639      +40     
==========================================
+ Hits         4052     4134      +82     
- Misses       1737     1862     +125     
- Partials      207      227      +20     
Flag Coverage Δ
unittests 66.43% <44.12%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyTMD/calc_astrol_longitudes.py 72.50% <ø> (ø)
pyTMD/load_constituent.py 88.88% <ø> (ø)
pyTMD/tools.py 0.00% <0.00%> (ø)
test/test_atlas_read.py 69.39% <ø> (ø)
test/test_download_and_read.py 92.17% <ø> (ø)
test/test_fes_predict.py 98.87% <ø> (ø)
test/test_perth3_read.py 99.15% <ø> (ø)
test/test_time.py 100.00% <ø> (ø)
pyTMD/model.py 23.29% <8.86%> (-1.31%) ⬇️
pyTMD/predict_tidal_ts.py 83.33% <33.33%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b5498...947626a. Read the comment docs.

@tsutterley tsutterley merged commit 8ee4ea5 into main Jul 1, 2022
@tsutterley tsutterley deleted the cat2022 branch July 1, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant