Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include prebuilt sample apps in tsky docs #86

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

shuuji3
Copy link
Collaborator

@shuuji3 shuuji3 commented Mar 13, 2025

resolve #85

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for tsky ready!

Name Link
🔨 Latest commit c592e30
🔍 Latest deploy log https://app.netlify.com/sites/tsky/deploys/67d2feb489b648000853425f
😎 Deploy Preview https://deploy-preview-86--tsky.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 13, 2025

Coverage Report for ./packages/client/

Status Category Percentage Covered / Total
🔵 Lines 13.64% 52 / 381
🔵 Statements 13.13% 52 / 396
🔵 Functions 9.6% 17 / 177
🔵 Branches 14.45% 12 / 83
File CoverageNo changed files found.
Generated in workflow #239 for commit c592e30 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/tsky-dev/tsky/@tsky/client@86

commit: c592e30

@shuuji3
Copy link
Collaborator Author

shuuji3 commented Mar 13, 2025

Hmm, the sample app is available at this URL: https://deploy-preview-86--tsky.netlify.app/examples/user-profile/

However, when you navigate from the Vitepress site (https://deploy-preview-86--tsky.netlify.app/examples/), it first shows a 404 page, and you need to reload the page.

I guess this is because Vitepress cannot know the existence of examples/ path during build time, so their router assumed this non-existing path was a missing route. I'm not sure how to tell Vitepress that the path /examples/user-profile/ should be out of the scope of Vitepress's responsibility.

@shuuji3
Copy link
Collaborator Author

shuuji3 commented Mar 13, 2025

The above issue was solved, and now it's ready.

ref. Routing | VitePress - https://vitepress.dev/guide/routing#linking-to-non-vitepress-pages

@shuuji3 shuuji3 merged commit ccbe864 into main Mar 15, 2025
9 checks passed
@shuuji3 shuuji3 deleted the shuuji3/docs/include-examples branch March 15, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy sample apps along with docs with Netlify
1 participant