-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add @tsky/lex-cli for generating typescript definitions #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anbraten <[email protected]>
✅ Deploy Preview for tsky canceled.
|
…nto feat/lex-cli-fork
@anbraten all set! |
anbraten
approved these changes
Dec 4, 2024
In general thanks again for the amazing work 👍🏾 . This will be a good starting point to continue building the client functions now. Would suggest to merge this as is and adjust further when necessary while using the types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
@tsky/lex-cli
, a TypeScript definition generator forked from@atcute/lex-cli
.Key changes:
@tsky/lex-cli
package based on@atcute/lex-cli
v1.0.3@tsky
namespace@externdefs/collider
toclipanion
@badrap/valita
totypanion
for schema validationThe PR includes generated type definitions for review in
packages/lexicons/src/lib/lexicons.ts
. Please review both the generator code and the resulting type definitions and let me know what you think!Edit: Following suggestion from mary, replaced symbolic type branding with a more pragmatic approach using concrete
$type
fields. This change:$type
) and RecordBase (required$type
)related to #30