Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA: Statistical test against external simulators #132

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

daikitag
Copy link
Collaborator

@daikitag daikitag commented Feb 8, 2024

The following steps are used in the statistical tests:

  1. Simulate a tree sequence data with 10 samples
  2. For each replicate, use tstrait to simulate phenotypes for each of the 10 individuals under a normal distribution trait model to get a per-individual phenotype distribution
  3. Repeat Step 2 with an external simulator
  4. Use QQ-plot to compare the outputs

The following simulators are used:

  1. simplePHENOTYPES
  2. AlphaSimR
  3. Quantitative trait simulation framework that is used in ARG-Needle paper

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (255539a) to head (d464469).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          351       351           
  Branches        50        50           
=========================================
  Hits           351       351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daikitag daikitag force-pushed the verification-other-simulator branch 3 times, most recently from b244d1c to 77fedca Compare February 8, 2024 13:26
@daikitag daikitag marked this pull request as draft February 11, 2024 18:08
@daikitag daikitag force-pushed the verification-other-simulator branch 3 times, most recently from fafdf62 to 1911174 Compare February 20, 2024 02:39
@daikitag daikitag marked this pull request as ready for review February 20, 2024 02:41
@daikitag daikitag marked this pull request as draft February 24, 2024 09:25
@daikitag daikitag marked this pull request as ready for review February 26, 2024 02:37
@daikitag daikitag force-pushed the verification-other-simulator branch 2 times, most recently from a315a53 to 6cdfef8 Compare March 5, 2024 16:24
@daikitag
Copy link
Collaborator Author

daikitag commented Mar 6, 2024

@jeromekelleher This is ready now, so would it be possible for you to check it whenever you have some time?

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think you need to delete the data directory?

Statistical tests against external simulators
@daikitag daikitag force-pushed the verification-other-simulator branch from 6cdfef8 to d464469 Compare March 6, 2024 09:08
@daikitag
Copy link
Collaborator Author

daikitag commented Mar 6, 2024

Looks good, but I think you need to delete the data directory?

I did not realize that, and thank you for pointing it out.

@mergify mergify bot merged commit 21b2bc5 into tskit-dev:main Mar 6, 2024
12 checks passed
@daikitag daikitag deleted the verification-other-simulator branch March 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate against simplePHENOTYPES Add statistical tests against existing simulator
2 participants