python3 -> python in Makefile

[hyanwong]

My installation doesn't bother defining python3 any more. I think we can assume python is v3 now

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (2fb6ab8) to head (b9a6363).
Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3023      +/-   ##
==========================================
- Coverage   89.84%   87.07%   -2.77%     
==========================================
  Files          29       11      -18     
  Lines       32097    24666    -7431     
  Branches     5756     4556    -1200     
==========================================
- Hits        28837    21478    -7359     
+ Misses       1859     1824      -35     
+ Partials     1401     1364      -37     

Flag	Coverage Δ
c-tests	86.69% <ø> (ø)
lwt-tests	80.78% <ø> (ø)
python-c-tests	89.05% <ø> (ø)
python-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

[benjeffery]

Yes, we're at the awkward point where some have removed python3 and some still have 2.x. I think we break on more people's machines with python3 now, so happy to change.

[jeromekelleher]

sorry I'm going to -1 this direct change as it breaks my setup, and I suspect will for Peter and a few others who regularly work with the C and are on Debian based Linux distros

Is there some other way to do this? Or can we just leave it for a bit?

[jeromekelleher]

See point about breaking stuff

[hyanwong]

Oh, sorry. I didn't realise there were still python2 installations out there. I guess just leave it until Debian links python -> python3?

Alternatively, sudo apt update && sudo apt install python-is-python3, according to https://unix.stackexchange.com/questions/609855/how-to-make-python-an-alias-of-python3-systemwide-on-debian?

[jeromekelleher]

Ah, hold on:

sudo apt install python-is-python3

sorts it.

Could we add python-is-python3 to the requirements listed here and elsewhere please? Maybe we could add a tip

[benjeffery]

What are you running? Python 2 got taken out of ubuntu 4 years ago.

[hyanwong]

What are you running? Python 2 got taken out of ubuntu 4 years ago.

I think Debian simply doesn't define a python (not even for python2, which is not installed by default anyway), unless you install python-is-python3

[jeromekelleher]

What are you running? Python 2 got taken out of ubuntu 4 years ago.

You don't get python -> to python3 automatically, you have to install python-is-python3 (which I haven't been doing, up to now).

So, I'm happy to make the change, we just need to update the development docs so that they work.

[benjeffery]

I've added a note to the docs and a friendly error message if the makefile finds python missing.

[jeromekelleher]

Nice, thanks Ben