-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reduction function in pair_coalescence_stat
#2975
Conversation
Because of the transposition, the output dimensions are now But, this doesn't agree with the time windowed stats draft #2948, so would be good to sort out now (@petrelharp). Maybe the pair coalescence stuff doesn't need to have the same output layout. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
- Coverage 89.90% 89.66% -0.24%
==========================================
Files 28 29 +1
Lines 23148 30435 +7287
Branches 4693 5905 +1212
==========================================
+ Hits 20811 27290 +6479
- Misses 1302 1799 +497
- Partials 1035 1346 +311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
More numpy 2 issues in the CI:
I'm guessing this is because the circleci workflow is using h5py 3.9.0, when we need 3.11.0 for numpy 2 compatibility. Why this didn't get hit yesterday on #2932 is mysterious ... |
Ready for a look whenever @jeromekelleher . Not sure where I'm going wrong with "codecov/project"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very pretty, great stuff! I just have one comment about division by zero.
Regarding the order of dimensions, I don't really have an opinion here and happy to go with what you and @petrelharp think. I'm happy to merge this and keep plugging forward while we figure it out.
4135408
to
22a8f66
Compare
Let's get this in then-- thanks! |
Followup to #2932
pair_coalescence_stat
, and change some naming conventions to be less confusingf(weights, values, params)
values
(which are node ages) also need to be aggregated. This is done by taking the weighted average of ages in each bin, which reduces to node ages if each node is in its own bin.