new_borrowed was unsound due to hiding the coupled lifetime

tskit-dev · Sep 21, 2023 · 58e1e51 · 58e1e51
1 parent 4f78b2c
commit 58e1e51
Showing 1 changed file with 0 additions and 14 deletions.
diff --git a/src/sys/tskbox.rs b/src/sys/tskbox.rs
@@ -21,15 +21,6 @@ impl<T> TskBox<T> {
         }
     }
 
-    pub fn new_borrowed(owner: &Self) -> Self {
-        let tsk = owner.tsk;
-        Self {
-            tsk,
-            teardown: None,
-            owning: false,
-        }
-    }
-
     pub fn as_ref(&self) -> &T {
         unsafe { self.tsk.as_ref() }
     }
@@ -86,10 +77,6 @@ fn test_miri() {
         },
         teardown_x,
     );
-
-    let _ = TskBox::new_borrowed(&b);
-
-    //is_send_sync(&b)
 }
 
 #[test]
@@ -112,5 +99,4 @@ fn test_table_collection_tskbox_shared_ptr() {
         },
         super::bindings::tsk_table_collection_free,
     );
-    let _ = TskBox::new_borrowed(&tables);
 }