Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote "author" function. #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Rewrote "author" function. #17

wants to merge 5 commits into from

Conversation

AphonicChaos
Copy link
Contributor

  • renamed to credits: seems more consistent with everything else
  • rewrote its implementation, as the old one didn't actually do anything but log it
  • you'll need to update the french version of the readme
  • this "breaks" the output since i removed the line wrapping in the file. I think a better place for this would be
    in the widget code itself. Eg, (Which I'll work on next).

@AphonicChaos
- renamed author() function to credits and reimplemented
d645535 
- moved CREDITS info into readme, mentioning the three ways to get the info
@AphonicChaos
- renamed about to credits (again, for consistency)
73231bb 
- added import to screens package:
	from usf.screens.screen import Screen
  is now:
  	from usf.screens import Screen
- might consider moving Screen class to __init__ if no one objects
@AphonicChaos
- simplified code in credits.py; stopped using 'magic' numbers
3b116a7
@AphonicChaos
- increased width of parpagraph widget; size is no longer hard coded
bdbe662 
- next up is to implement wrapping
@AphonicChaos
- manually wrapped CREDITS files again. Want the program without
0066d06 
  defects as i work on a new impolementation -- new branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AphonicChaos