Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning SONiC code with sff8024 spec #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tshalvi
Copy link
Owner

@tshalvi tshalvi commented Apr 12, 2024

Description

I updated sff8024.py to align with the SFF8024 spec by implementing fixes and additions. Additionally, I resolved an issue in the method responsible for retrieving the application advertisement list from the EEPROM of CMIS modules.

Motivation and Context

We encountered an issue with the application advertisement list retrieved from the get_application_advertisement() method for a specific module. Despite the EEPROM indicating support for 6 applications, the method returned only one application. This discrepancy appeared because the EEPROM's application advertisement list was missing information for the SECOND application. The implementation of get_application_advertisement() in cmis.py would terminate prematurely if information was missing for any application, causing subsequent applications to be overlooked.
To address this issue, this PR introduces two changes:

  1. Updates the get_application_advertisement() method to continue processing even if information is missing for an application, proceeding to the next application instead.
  2. Updates sff8024.py to include information for ALL applications specified in the SFF8024 spec (including the application that was missing in the original issue ofc)

How Has This Been Tested?

I verified that the missing application in sff8024.py could be successfully detected in the module's EEPROM application advertisement list.

Additional Information (Optional)

@tshalvi tshalvi changed the base branch from master to platform_common_changes_after_POCs May 6, 2024 12:28
@tshalvi tshalvi changed the base branch from platform_common_changes_after_POCs to master May 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants