Count success based on error and status code

tsenart · Sep 1, 2023 · 4a5cee2 · 4a5cee2
1 parent 3b557d6
commit 4a5cee2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/metrics.go b/lib/metrics.go
@@ -69,7 +69,7 @@ func (m *Metrics) Add(r *Result) {
 		m.End = end
 	}
 
-	if r.Code >= 200 && r.Code < 400 {
+	if r.Code >= 200 && r.Code < 400 && (r.Error == "") {
 		m.success++
 	}
 

diff --git a/lib/metrics_test.go b/lib/metrics_test.go
@@ -62,8 +62,8 @@ func TestMetrics_Add(t *testing.T) {
 		Wait:        duration("10ms"),
 		Requests:    10000,
 		Rate:        1.000100010001,
-		Throughput:  0.6667660098349737,
-		Success:     0.6667,
+		Throughput:  0.3333329999669967,
+		Success:     0.3333,
 		StatusCodes: map[string]int{"500": 3333, "200": 3334, "302": 3333},
 		Errors:      []string{"Internal server error"},