fix(prisma): resolve multiple enums on model not correctly imported #2941
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces changes to the Prisma ORM configuration and test setup for the Changes
Assessment against linked issues
Possibly related PRs
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (54)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range comments (1)
packages/orm/prisma/test/enums/package.json (1)
Line range hint
4-9: Consider updating Prisma dependenciesThe current Prisma dependencies are locked to version ^4.0.0, which is quite old. Consider updating to the latest stable version (5.x) to benefit from performance improvements, bug fixes, and new features.
"devDependencies": { - "prisma": "^4.0.0" + "prisma": "^5.7.0" }, "dependencies": { - "@prisma/client": "^4.0.0" + "@prisma/client": "^5.7.0" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
packages/orm/prisma/test/mongo/package-lock.jsonis excluded by!**/package-lock.jsonpackages/orm/prisma/test/postgres/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (10)
packages/orm/prisma/package.json(1 hunks)packages/orm/prisma/src/generator/domain/DmmfModel.ts(2 hunks)packages/orm/prisma/test/enums/package.json(1 hunks)packages/orm/prisma/test/enums/prisma/schema.prisma(1 hunks)packages/orm/prisma/test/mongo-esm/package.json(1 hunks)packages/orm/prisma/test/mongo/package.json(0 hunks)packages/orm/prisma/test/mongo/prisma/schema.prisma(0 hunks)packages/orm/prisma/test/mongo/prisma/tsconfig.json(0 hunks)packages/orm/prisma/test/postgres/prisma/schema.prisma(0 hunks)packages/orm/prisma/test/postgres/tsconfig.json(0 hunks)
💤 Files with no reviewable changes (5)
- packages/orm/prisma/test/mongo/package.json
- packages/orm/prisma/test/mongo/prisma/tsconfig.json
- packages/orm/prisma/test/postgres/tsconfig.json
- packages/orm/prisma/test/mongo/prisma/schema.prisma
- packages/orm/prisma/test/postgres/prisma/schema.prisma
🧰 Additional context used
🪛 Biome (1.9.4)
packages/orm/prisma/src/generator/domain/DmmfModel.ts
[error] 70-70: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
🔇 Additional comments (9)
packages/orm/prisma/test/enums/package.json (1)
3-3: LGTM! ES module configuration is appropriate.
The change to ES modules aligns with modern JavaScript practices and maintains consistency with other packages in the codebase.
packages/orm/prisma/test/mongo-esm/package.json (1)
Line range hint 1-9: Changes mirror those in enums/package.json
The modifications are identical to those in the enums test package and maintain consistency across the test suite.
packages/orm/prisma/test/enums/prisma/schema.prisma (3)
2-5: LGTM! Standard PostgreSQL datasource configuration.
The datasource configuration follows best practices by using an environment variable for the database URL.
19-25: LGTM! Well-structured User model with enum fields.
The User model effectively demonstrates the use of multiple enums with appropriate default values.
7-11: Verify binary targets necessity
The client generator includes specific binary targets. Please verify if all these targets are necessary for your testing environment.
✅ Verification successful
Binary targets configuration is consistent across test schemas
The binary targets configuration appears in multiple test schema files with the same targets (native, windows, debian-openssl-1.1.x), indicating this is a deliberate setup for the test environment. This consistent pattern across different test scenarios (postgres-esm, mongo-esm, circular-ref, enums) suggests these targets are intentionally maintained for comprehensive testing coverage.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if these binary targets are used in other test configurations
rg -l "binaryTargets.*windows" -g "schema.prisma"
rg -l "binaryTargets.*debian-openssl-1.1.x" -g "schema.prisma"
Length of output: 564
Script:
#!/bin/bash
# Let's check the test configurations and CI workflows to understand the testing environments
rg -l "runs-on.*windows" .github/
rg -l "runs-on.*ubuntu" .github/
rg "matrix.*os.*windows" .github/
Length of output: 298
Script:
#!/bin/bash
# Let's check the package.json files in test directories to understand test environments
fd package.json packages/orm/prisma/test/ --exec cat {}
Length of output: 707
packages/orm/prisma/package.json (1)
27-27: LGTM: New script for enum generation
The added script follows the established pattern and provides necessary infrastructure for testing enum handling.
packages/orm/prisma/src/generator/domain/DmmfModel.ts (3)
70-72: LGTM: Critical fix for enum import handling
Moving the resolveExtension call before the imports check ensures consistent module paths, which is essential for correctly handling multiple enum imports. This change prevents potential duplicate or incorrect imports due to unresolved module specifiers.
🧰 Tools
🪛 Biome (1.9.4)
[error] 70-70: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
82-86: LGTM: Improved type safety and import consistency
Good improvements:
- Explicit
string[]typing enhances type safety - Sorting named imports ensures consistent ordering and prevents duplicates
Line range hint 70-89: Verify enum import handling
Let's verify that the changes properly handle multiple enum imports and don't cause regressions.
✅ Verification successful
Import handling implementation verified successfully
Based on the comprehensive verification results, the changes properly handle multiple enum imports and maintain existing import functionality:
-
The
addImportDeclarationimplementation inDmmfModel.tscorrectly:- Maintains a map of unique imports
- Properly accumulates named imports
- Sorts imports to maintain consistency
- Handles type-only imports appropriately
-
Evidence from the generated code (
UserModel.ts) shows proper enum handling:- Correct import of
Roleenum from../enums/index.js - Proper usage with
@Enum(Role)decorator - No duplicate imports
- Correct import of
-
The implementation is well-tested as shown by
transformScalarToType.spec.tswhich verifies enum import declarations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for enum import patterns and potential issues
# Look for enum definitions in Prisma schemas
echo "Checking Prisma schemas for enum definitions..."
fd -e prisma | xargs rg "enum.*{" -A 5
# Look for generated enum imports to verify correct handling
echo "Checking generated files for enum imports..."
fd -e ts -e js | xargs rg "import.*enum" -A 2
Length of output: 3505
Script:
#!/bin/bash
# Let's improve our verification with better patterns
# Check enum handling in DmmfModel.ts and related files
echo "Checking DmmfModel enum handling implementation..."
rg -A 5 "addImport.*enum" packages/orm/prisma/src/
# Look for enum-related test cases
echo "Checking enum-related test cases..."
rg -A 10 "describe.*enum" packages/orm/prisma/test/
# Check actual enum import statements in generated code
echo "Checking generated enum imports..."
fd ".*Model.ts" packages/orm/prisma/test/snapshots/ -x rg "import.*enum" -l {}
# Check for multiple enum imports in a single file
echo "Checking for multiple enum imports pattern..."
fd ".*Model.ts" packages/orm/prisma/test/snapshots/ -x rg "import.*\{.*,.*\}.*enum" {}
Length of output: 2044
Script:
#!/bin/bash
# Let's check the actual implementation and test coverage
# Check the enum import handling implementation
echo "Checking DmmfModel implementation..."
ast-grep --pattern 'class DmmfModel {
$$$
addImportDeclaration($$$) {
$$$
}
$$$
}'
# Check the test coverage for enum imports
echo "Checking test coverage for enum imports..."
rg -B 5 -A 10 "test.*enum.*import" packages/orm/prisma/test/
# Check the generated model content to verify import handling
echo "Checking generated model content..."
cat packages/orm/prisma/test/snapshots/generate_code/models/UserModel.ts
# Check enum registry implementation
echo "Checking enum registry..."
fd -e ts -t f | xargs rg "class.*DmmfEnum" -A 10
Length of output: 10193
🧰 Tools
🪛 Biome (1.9.4)
[error] 81-81: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
| enum Role { | ||
| USER | ||
| ADMIN | ||
| } | ||
|
|
||
| enum Provider { | ||
| GITHUB | ||
| MICROSOFT | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider documenting enum values
The Role and Provider enums are well-defined but could benefit from documentation comments explaining the purpose of each value.
enum Role {
+ /// Regular user with standard permissions
USER
+ /// Administrator with elevated permissions
ADMIN
}
enum Provider {
+ /// Standard email-based authentication
EMAIL
+ /// Facebook OAuth provider
FACEBOOK
+ /// Google OAuth provider
GOOGLE
+ /// GitHub OAuth provider
GITHUB
+ /// Microsoft OAuth provider
MICROSOFT
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| enum Role { | |
| USER | |
| ADMIN | |
| } | |
| enum Provider { | |
| GITHUB | |
| MICROSOFT | |
| } | |
| enum Role { | |
| /// Regular user with standard permissions | |
| USER | |
| /// Administrator with elevated permissions | |
| ADMIN | |
| } | |
| enum Provider { | |
| /// Standard email-based authentication | |
| /// Facebook OAuth provider | |
| /// Google OAuth provider | |
| /// GitHub OAuth provider | |
| GITHUB | |
| /// Microsoft OAuth provider | |
| MICROSOFT | |
| } |
| generator tsed { | ||
| provider = "node ../../lib/esm/generator.js" | ||
| output = "../prisma/generated/tsed" | ||
| emitDMMF = true | ||
| } |
There was a problem hiding this comment.
💡 Codebase verification
The generator path needs to be updated
The path node ../../lib/esm/generator.js in the Prisma schema is incorrect as:
- The source code shows the generator is located at
src/generator.ts - The build directory
libis not present in the expected location - The project uses TypeScript with build configuration, but the build hasn't been executed
Please update the generator path in the schema to point to the source TypeScript file or ensure the build process is completed before running Prisma generate.
🔗 Analysis chain
Verify TSED generator configuration
The local generator script path assumes a specific build output structure. Ensure this path remains valid after the build process.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the generator script exists and is executable
fd -t f "generator.js" "packages/orm/prisma/lib/esm"
Length of output: 165
Script:
#!/bin/bash
# Let's first check the actual directory structure to locate the generator file
fd -t f "generator.js" packages/orm
# Also check package.json to understand build configuration
fd -t f "package.json" packages/orm -x cat {}
Length of output: 13640
Script:
#!/bin/bash
# Let's check the source directory structure and build configuration
fd -t f "generator.ts" packages/orm/prisma
fd -t f "tsconfig.json" packages/orm/prisma -x cat {}
# Check if the build directory exists
fd -t d "lib" packages/orm/prisma
Length of output: 1137
Romakita
force-pushed
the
fix-prisma-enums
branch
from
9ce84ac to
79b7095
Compare
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.
Actionable comments posted: 14
🧹 Outside diff range comments (7)
docs/introduction/what-is-news-v8.md (3)
Line range hint
25-185: Consider enhancing code examples with inline comments.The code examples effectively demonstrate the differences between v7 and v8 approaches. Consider adding more inline comments to explain key concepts, especially in the factory and hooks examples.
Example enhancement for the factory code:
export const CONNECTION = injectable<DatabaseConnection>(Symbol.for("CONNECTION")) + // Configure the factory function to create the database connection .factory(() => { const options = constant<Options>("myOptions"); return new DatabaseConnection(options); }) + // Define lifecycle hooks for cleanup .hooks({ $onDestroy(connection) { return connection.close(); } }) .token();
Line range hint
1-185: Documentation effectively covers v8 changes and migration path.The documentation comprehensively covers the new features and changes in v8, with a good balance of explanations and practical examples. The architectural changes, especially around dependency injection and hooks, are well explained.
Consider adding a section about:
- Performance implications of the new DI approach
- Best practices for organizing providers with the new functional API
- Migration strategies for large codebases
Documentation links need path correction
The referenced files exist but with slightly different paths than those used in the documentation:
/docs/hooksshould be/docs/docs/hooks/docs/providers.mdshould be/docs/docs/providers.md/introduction/migrate-from-v7should be/docs/introduction/migrate-from-v7.md/tutorials/graphql.htmlshould be/docs/tutorials/graphql.mdPlease update the relative paths in the documentation to match the actual file structure.
🔗 Analysis chain
Line range hint
10-24: Verify documentation links are valid.The documentation includes several relative links to other sections. Let's verify they are valid and accessible.
Let me try another verification approach to check if the files might be in different locations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if referenced documentation files exist # Note: Only checking local files as external URLs aren't accessible in the sandbox # Check for referenced markdown files echo "Checking referenced markdown files..." for path in docs/hooks.md docs/providers.md introduction/migrate-from-v7.md tutorials/graphql.md; do if [ -f "$path" ]; then echo "✓ Found: $path" else echo "✗ Missing: $path" fi doneLength of output: 911
Script:
#!/bin/bash # Search for the referenced files anywhere in the repository echo "Searching for documentation files..." fd -e md -e mdx hooks fd -e md -e mdx providers fd -e md -e mdx migrate-from-v7 fd -e md -e mdx graphql # Also check if there might be a docs directory with a different structure echo -e "\nChecking docs directory structure:" fd -t d docsLength of output: 674
docs/tutorials/vitest.md (1)
Line range hint
10-100: Consider enhancing the Vitest configurationThe Vitest setup guide is well-structured, but consider adding these improvements:
- Add environment setup for Prisma testing
- Include example test cases, especially for testing Prisma models and enums
- Add a section about mocking Prisma Client
Would you like me to provide example configurations and test cases for these improvements?
docs/tutorials/prisma.md (2)
Line range hint
12-24: Consider environment-specific database configurationsWhile the configuration is correct, consider adding environment-specific database configurations and documenting security best practices for handling database URLs in production.
Consider adding a note about securing database credentials:
DATABASE_URL="file:./dev.db" +# For production: +# DATABASE_URL="postgresql://${DB_USER}:${DB_PASS}@${DB_HOST}:${DB_PORT}/${DB_NAME}?schema=public"
Line range hint
450-550: Add error handling examples in the controller sectionThe controller examples would benefit from proper error handling examples, especially for database operations that might fail.
Consider adding error handling examples:
@Post("/") @Summary("Create a new user") @Returns(201, UserModel) async signupUser(@BodyParams() @Groups("creation") user: UserModel): Promise<UserModel> { + try { return this.service.create({data: user}); + } catch (error) { + // Handle unique constraint violations + if (error.code === 'P2002') { + throw new Conflict('User already exists'); + } + throw error; + } }docs/docs/model.md (1)
Line range hint
1000-1050: Enhance visibility of breaking change warningThe Groups strict mode documentation should more prominently highlight this is a breaking change in the next major version.
Consider adding a more visible warning:
-::: warning +::: danger BREAKING CHANGE The `strictGroups` option is enabled by default in the next major version of Ts.ED. +This will affect how your models are serialized/deserialized when no groups are specified. :::
🛑 Comments failed to post (14)
docs/docs/hooks.md (1)
1-9: 🧹 Nitpick (assertive)
LGTM! The added metadata enhances documentation discoverability.
The added meta tags improve SEO with relevant description and keywords that accurately represent the content of the hooks documentation.
Consider adding the following keywords to make it even more comprehensive:
- "lifecycle events"
- "hooks implementation"
- "event handling"
- - meta - name: keywords - content: hooks ts.ed framework express typescript node.js javascript decorators mvc class models providers pipes middlewares testing developer + content: hooks lifecycle events hooks implementation event handling ts.ed framework express typescript node.js javascript decorators mvc class models providers pipes middlewares testing developer📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.--- head: - - meta - name: description content: Discover how to use hooks in Ts.ED to subscribe to lifecycle events and perform actions when they occur. - - meta - name: keywords content: hooks lifecycle events hooks implementation event handling ts.ed framework express typescript node.js javascript decorators mvc class models providers pipes middlewares testing developer ---docs/introduction/migrate-from-v7.md (3)
294-294: 🧹 Nitpick (assertive)
Add verification step for ESM migration.
Consider adding a verification step to help users identify any remaining CommonJS imports that need to be updated.
Add this section after the ESM migration steps:
### Verify ESM Migration You can use the following command to identify any remaining CommonJS imports that need to be updated: ```shell find src -type f -name "*.ts" -exec grep -l "require(" {} \;This will help catch any missed CommonJS
require()calls in your codebase.--- 294-294: _:broom: Nitpick (assertive)_ **Structure the optimization steps as a checklist.** Consider restructuring the optimization section to include a clear checklist of steps. Add this checklist format: ```markdown ### Optimization Checklist 1. [ ] Replace package dependencies - Uninstall `@tsed/common` - Install `@tsed/platform-http` 2. [ ] Update imports - [ ] Replace `import {PlatformTest} from "@tsed/common"` with `import {PlatformTest} from "@tsed/platform-http/testing"` - [ ] Update schema imports from `@tsed/schema` - [ ] Update DI imports from `@tsed/di` - [ ] Update platform imports from respective packages 3. [ ] Verify changes - [ ] Run the application - [ ] Check for any missing imports - [ ] Test affected functionality
294-294: 🧹 Nitpick (assertive)
Add warning about CommonJS import syntax.
The import syntax example
import * as fs from "fs-extra"should include a note about potential TypeScript compilation errors ifesModuleInteropis not properly configured.Consider adding this warning note:
import * as fs from "fs-extra"; + +::: warning +If you get TypeScript errors about namespace imports, ensure `esModuleInterop` is set to `true` in your tsconfig.json. +:::📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.import * as fs from "fs-extra"; ::: warning If you get TypeScript errors about namespace imports, ensure `esModuleInterop` is set to `true` in your tsconfig.json. :::docs/tutorials/vitest.md (1)
1-1:
⚠️ Potential issueMissing code changes for fixing Prisma enum imports
This PR claims to fix multiple enum imports in Prisma models (issue #2939), but only contains documentation improvements. Please include the necessary code changes to address the Prisma enum import issue or update the PR description to reflect its actual purpose of documentation improvements.
docs/tutorials/jest.md (2)
10-10: 🧹 Nitpick (assertive)
Consider adding Node.js version compatibility information.
It would be helpful to specify the minimum Node.js version required for this Jest setup, as Jest's functionality can vary across Node.js versions.
2-8: 🧹 Nitpick (assertive)
Consider enhancing keywords with testing-specific terms.
While the current metadata is good, consider adding testing-specific keywords like "testing", "unit-testing", "test-runner" to improve discoverability.
docs/tutorials/graphql.md (1)
7-8:
⚠️ Potential issueKeywords should reflect all supported GraphQL implementations
The keywords list has removed "nexus" and "typegraphql" despite the document containing sections about both Nexus and TypeGraphQL. Consider restoring these keywords to maintain consistency with the document content.
Apply this diff to restore the relevant keywords:
- content: ts.ed express koa typescript apollo node.js javascript decorators + content: ts.ed express koa typescript apollo nexus typegraphql node.js javascript decorators📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- name: keywords content: ts.ed express koa typescript apollo nexus typegraphql node.js javascript decoratorsdocs/tutorials/pulse.md (2)
1-1:
⚠️ Potential issuePR content does not match stated objective.
This PR claims to fix "multiple enums on model not correctly imported" in Prisma, but the changes only include documentation metadata updates. Either:
- The actual code changes are missing from this review, or
- This PR's description needs to be updated to reflect its true purpose of improving documentation metadata.
Please clarify the intent of this PR and ensure all relevant changes are included.
4-5: 🧹 Nitpick (assertive)
Fix typo in meta description.
There's a typo in the description: "for of Agenda" should be "fork of Agenda"
- content: Use Pulse cron with Express/Koa, TypeScript and Ts.ED. Pulse is a maintained for of Agenda, a light-weight job scheduling library for Node.js + content: Use Pulse cron with Express/Koa, TypeScript and Ts.ED. Pulse is a maintained fork of Agenda, a light-weight job scheduling library for Node.js📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- name: description content: Use Pulse cron with Express/Koa, TypeScript and Ts.ED. Pulse is a maintained fork of Agenda, a light-weight job scheduling library for Node.jsdocs/tutorials/temporal.md (1)
2-8: 🧹 Nitpick (assertive)
Maintain consistent casing in keywords
The keywords list contains mixed casing: "Express" and "koa". Consider standardizing to lowercase for consistency, as "koa" is already in lowercase.
- content: ts.ed express koa typescript temporal.io temporal node.js javascript decorators + content: ts.ed express koa typescript temporal.io temporal node.js javascript decoratorsCommittable suggestion skipped: line range outside the PR's diff.
docs/tutorials/keycloak.md (1)
2-8: 🧹 Nitpick (assertive)
Consider expanding keywords for better discoverability
While the current keywords are relevant, consider adding more specific terms related to authentication and security to improve discoverability.
- content: ts.ed express typescript keycloak node.js javascript decorators + content: ts.ed express typescript keycloak node.js javascript decorators authentication security sso oauth identity-management📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.head: - - meta - name: description content: Use Keycloak with Express, TypeScript and Ts.ED to secure your application. - - meta - name: keywords content: ts.ed express typescript keycloak node.js javascript decorators authentication security sso oauth identity-managementdocs/tutorials/ajv.md (1)
2-8:
⚠️ Potential issueReview metadata keywords for consistency with content.
The keywords list includes "koa" but the documentation content primarily references Express. This might be misleading for users searching for Koa-specific implementation details.
Consider either:
- Keeping "express" in keywords if the content is Express-specific
- Adding Koa-specific implementation details to the documentation
docs/tutorials/mongoose.md (1)
2-8:
⚠️ Potential issueReview keywords in metadata
The keywords list includes "koa" while removing "mongoose", which seems inconsistent with the document's content and purpose. The document is specifically about Mongoose integration, so "mongoose" should be retained in the keywords.
content: mongoose ts.ed express koa typescript node.js javascript decorators - content: mongoose ts.ed express koa typescript node.js javascript decorators + content: mongoose ts.ed express typescript node.js javascript decoratorsCommittable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Outside diff range comments (6)
docs/introduction/what-is-news-v8.md (1)
Line range hint
10-24: Consider adding a version compatibility table.The documentation comprehensively covers the new features and migration path. To make it even more helpful, consider adding a version compatibility table that shows:
- Minimum required Node.js version
- Supported TypeScript versions
- Compatible package versions (Express, Apollo, etc.)
Example table format:
| Dependency | Minimum Version | Maximum Version | |------------|----------------|-----------------| | Node.js | x.x.x | x.x.x | | TypeScript | x.x.x | x.x.x | | Express | x.x.x | x.x.x | | Apollo | 4.x.x | x.x.x |🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...s on improved dependency injection that let you access the [injector instance every...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
docs/docs/response-filter.md (1)
Line range hint
1-100: Consider enhancing the code examples.The XML filter example uses an undefined
jsToXMLfunction. Consider:
- Adding a note about which XML library to use
- Providing a complete example with a specific XML library
Would you like me to provide an enhanced example using a specific XML library like
xml2jsorfast-xml-parser?docs/introduction/migrate-from-v7.md (1)
Line range hint
1-24: Consider adding sections for breaking changes and troubleshooting.The migration guide is comprehensive but could be enhanced with:
- A dedicated "Breaking Changes" section listing all incompatible changes
- A "Troubleshooting" section covering common migration issues and their solutions
- A "Migration Checklist" for users to track their progress
This would help users better prepare for and execute the migration.
docs/tutorials/jest.md (2)
Line range hint
39-63: Enhance Jest configuration with additional TypeScript settings.The current configuration misses some important settings that could improve TypeScript integration:
export default { + preset: 'ts-jest', + rootDir: '.', // Automatically clear mock calls and instances between every test clearMocks: true, // ... other settings ... transform: { "\\.(ts)$": "ts-jest" - } + }, + moduleNameMapper: { + '^@/(.*)$': '<rootDir>/src/$1' + } };These additions will:
- Use ts-jest preset for better TypeScript integration
- Set the root directory explicitly
- Add support for path aliases if you're using them in your TypeScript configuration
🧰 Tools
🪛 Markdownlint (0.37.0)
13-13: Element: Banner
Inline HTML(MD033, no-inline-html)
Line range hint
76-86: Enhance test scripts with additional configurations.Consider adding more specific test commands and using TypeScript for e2e configuration:
{ "scripts": { "test": "jest", + "test:unit": "jest --testMatch=\"**/src/**/?(*.)+(spec|test).[tj]s?(x)\"", "test:watch": "jest --watch", "test:cov": "jest --coverage", "test:debug": "node --inspect-brk -r ts-node/register node_modules/.bin/jest --runInBand", - "test:e2e": "jest --config ./jest.config.e2e.js" + "test:e2e": "jest --config ./jest.config.e2e.ts" } }Also, consider adding a note about setting the
NODE_ENV=testenvironment variable when running tests.🧰 Tools
🪛 Markdownlint (0.37.0)
13-13: Element: Banner
Inline HTML(MD033, no-inline-html)
docs/tutorials/vitest.md (1)
Line range hint
10-24: Consider adding Node.js version compatibility information.Since Vitest and SWC have specific Node.js version requirements, it would be helpful to specify the minimum supported Node.js version in the introduction section.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/orm/prisma/src/generator/utils/__snapshots__/generateModels.spec.ts.snapis excluded by!**/*.snappackages/orm/prisma/test/mongo/package-lock.jsonis excluded by!**/package-lock.jsonpackages/orm/prisma/test/postgres/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (66)
docs/docs/authentication.md(1 hunks)docs/docs/controllers.md(1 hunks)docs/docs/custom-providers.md(1 hunks)docs/docs/hooks.md(1 hunks)docs/docs/injection-scopes.md(1 hunks)docs/docs/interceptors.md(1 hunks)docs/docs/json-mapper.md(1 hunks)docs/docs/model.md(1 hunks)docs/docs/not-found-page.md(1 hunks)docs/docs/pipes.md(1 hunks)docs/docs/platform-api.md(1 hunks)docs/docs/providers.md(1 hunks)docs/docs/request-context.md(1 hunks)docs/docs/response-filter.md(1 hunks)docs/docs/session.md(1 hunks)docs/docs/testing.md(1 hunks)docs/docs/validation.md(1 hunks)docs/getting-started.md(1 hunks)docs/introduction/capabilities.md(1 hunks)docs/introduction/create-your-first-controller.md(1 hunks)docs/introduction/getting-started.md(1 hunks)docs/introduction/migrate-from-v7.md(2 hunks)docs/introduction/what-is-news-v8.md(1 hunks)docs/introduction/what-is-tsed.md(1 hunks)docs/tutorials/agenda.md(1 hunks)docs/tutorials/ajv.md(1 hunks)docs/tutorials/aws.md(1 hunks)docs/tutorials/bullmq.md(1 hunks)docs/tutorials/graphql-apollo.md(1 hunks)docs/tutorials/graphql-nexus.md(1 hunks)docs/tutorials/graphql-typegraphql.md(1 hunks)docs/tutorials/graphql-ws.md(1 hunks)docs/tutorials/graphql.md(1 hunks)docs/tutorials/ioredis.md(1 hunks)docs/tutorials/jest.md(1 hunks)docs/tutorials/keycloak.md(1 hunks)docs/tutorials/mikroorm.md(1 hunks)docs/tutorials/mongoose.md(1 hunks)docs/tutorials/objection.md(1 hunks)docs/tutorials/oidc.md(1 hunks)docs/tutorials/passport.md(1 hunks)docs/tutorials/prisma.md(1 hunks)docs/tutorials/pulse.md(1 hunks)docs/tutorials/scalar.md(1 hunks)docs/tutorials/server-sent-events.md(1 hunks)docs/tutorials/serverless.md(1 hunks)docs/tutorials/socket-io.md(1 hunks)docs/tutorials/stripe.md(1 hunks)docs/tutorials/swagger.md(1 hunks)docs/tutorials/temporal.md(1 hunks)docs/tutorials/terminus.md(1 hunks)docs/tutorials/typeorm.md(1 hunks)docs/tutorials/vike.md(1 hunks)docs/tutorials/vitest.md(1 hunks)packages/orm/prisma/package.json(1 hunks)packages/orm/prisma/src/generator/domain/DmmfModel.ts(2 hunks)packages/orm/prisma/test/enums/package.json(1 hunks)packages/orm/prisma/test/enums/prisma/schema.prisma(1 hunks)packages/orm/prisma/test/mongo-esm/package.json(1 hunks)packages/orm/prisma/test/mongo/package.json(0 hunks)packages/orm/prisma/test/mongo/prisma/schema.prisma(0 hunks)packages/orm/prisma/test/mongo/prisma/tsconfig.json(0 hunks)packages/orm/prisma/test/postgres/prisma/schema.prisma(0 hunks)packages/orm/prisma/test/postgres/tsconfig.json(0 hunks)packages/orm/prisma/test/snapshots/generate_code/models/PostModel.ts(1 hunks)packages/orm/prisma/test/snapshots/generate_code/models/UserModel.ts(1 hunks)
💤 Files with no reviewable changes (5)
- packages/orm/prisma/test/postgres/tsconfig.json
- packages/orm/prisma/test/mongo/prisma/tsconfig.json
- packages/orm/prisma/test/mongo/package.json
- packages/orm/prisma/test/mongo/prisma/schema.prisma
- packages/orm/prisma/test/postgres/prisma/schema.prisma
👮 Files not reviewed due to content moderation or server errors (3)
- docs/docs/controllers.md
- docs/tutorials/prisma.md
- docs/docs/model.md
🧰 Additional context used
🪛 Biome (1.9.4)
packages/orm/prisma/src/generator/domain/DmmfModel.ts
[error] 70-70: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
🔇 Additional comments (55)
docs/docs/session.md (1)
1-9: LGTM: Metadata enhances documentation discoverability
The added metadata improves SEO and documentation findability with relevant description and keywords.
docs/introduction/what-is-news-v8.md (1)
1-9: LGTM! Well-structured meta tags for SEO optimization.
The meta tags provide comprehensive description and relevant keywords that accurately represent the v8 features and improvements.
docs/introduction/migrate-from-v7.md (1)
8-8: LGTM! Keywords update improves searchability.
The addition of "v7" to the meta keywords will help users find this migration guide when searching for version-specific information.
docs/tutorials/jest.md (1)
Line range hint 1-86: Verify the relevance of Jest documentation changes.
This documentation change introduces Jest setup instructions, but the PR's objective is to fix Prisma enum imports. Could you clarify how this documentation change relates to the Prisma enum fix?
🧰 Tools
🪛 Markdownlint (0.37.0)
13-13: Element: Banner
Inline HTML
(MD033, no-inline-html)
packages/orm/prisma/test/snapshots/generate_code/models/PostModel.ts (1)
2-2: LGTM, but verify if import reordering is intentional
The changes only reorder imports from @tsed/schema. Since this is generated code, please confirm if this reordering is an intended side effect of the enum import fix.
packages/orm/prisma/test/snapshots/generate_code/models/UserModel.ts (1)
2-2: Verify enum handling implementation
While the import changes look correct, let's verify if this addresses the multiple enum import issue:
- The Role enum is correctly imported from "../enums/index.js"
- The @enum decorator is properly applied to the role property
✅ Verification successful
Based on the results, I can now generate the final response:
Enum handling implementation is correctly implemented
The codebase scan shows consistent and correct enum handling patterns:
- The
@Enumdecorator is properly used across the codebase with both string literals and enum types - The Role enum import and usage in UserModel.ts follows the established pattern seen in other models
- No issues found with multiple enum declarations or conflicting implementations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for multiple enum usage patterns and their imports
echo "Checking enum import patterns:"
ast-grep --pattern 'import { $enum } from "$path/enums"'
echo "Checking @Enum decorator usage:"
ast-grep --pattern '@Enum($type)'
echo "Checking for multiple enum declarations in models:"
rg -A 5 "@Enum\("
Length of output: 34938
packages/orm/prisma/test/enums/package.json (2)
3-3: LGTM: ES module configuration
The change to ES modules is appropriate and aligns with modern JavaScript practices.
Line range hint 4-9: Consider updating Prisma dependencies
The current Prisma version (^4.0.0) is outdated. Consider upgrading to the latest stable version (5.x) to benefit from security patches, bug fixes, and new features.
packages/orm/prisma/test/mongo-esm/package.json (1)
Line range hint 3-9: Same concerns as in enums/package.json
The same observations about ES modules and Prisma versions apply here.
packages/orm/prisma/test/enums/prisma/schema.prisma (5)
2-5: LGTM: Database configuration
The PostgreSQL datasource configuration is properly set up with environment variable usage.
13-17: The generator path needs to be updated
The path node ../../lib/esm/generator.js in the Prisma schema is incorrect as:
- The source code shows the generator is located at
src/generator.ts - The build directory
libis not present in the expected location - The project uses TypeScript with build configuration, but the build hasn't been executed
19-25: LGTM: Model definition with enum usage
The User model correctly implements the enum fields with appropriate defaults. This addresses the PR objective of fixing multiple enum imports.
27-38: Consider documenting enum values
The Role and Provider enums are well-defined but could benefit from documentation comments explaining the purpose of each value.
23-24: 🧹 Nitpick (assertive)
Verify enum default values
Ensure that the default values (USER and EMAIL) are appropriate for your use case and that they're handled correctly in the application logic.
✅ Verification successful
Based on the search results, I can make a determination. The code shows:
- The Role enum is defined with two values: USER and ADMIN
- The Provider enum is defined with EMAIL as one of its values
- These enums are used in a test schema with default values (USER and EMAIL respectively)
- The context shows this is test code under
packages/orm/prisma/test/
Default values are appropriate and handled correctly
The default values (USER and EMAIL) are standard choices that align with common authentication patterns:
- USER as default role provides least-privilege access by default
- EMAIL as default provider is the most common authentication method
The test location and usage patterns indicate these are well-tested default values that are handled appropriately in the application logic.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for references to these default values in the codebase
rg "Role\.USER" -A 5
rg "Provider\.EMAIL" -A 5
Length of output: 50
Script:
#!/bin/bash
# Let's check the enum definitions and their usage patterns
ast-grep --pattern 'enum Role {
$$$
}'
ast-grep --pattern 'enum Provider {
$$$
}'
# Let's also check for any direct string references
rg -i "user.*role|role.*user" -A 3
rg -i "email.*provider|provider.*email" -A 3
# Check for any TypeScript/JavaScript type definitions or interfaces using these enums
fd -e ts -e js -e tsx -e jsx --exec grep -l "Role\|Provider" {} \;
Length of output: 75018
docs/tutorials/aws.md (1)
2-8: LGTM: Clean metadata restructuring
The metadata reorganization under the head key follows a consistent pattern while preserving the existing SEO content.
docs/docs/not-found-page.md (1)
1-9: LGTM: Well-structured SEO metadata
The added metadata provides clear description and relevant keywords for the 404 customization documentation.
docs/introduction/what-is-tsed.md (1)
1-9: LGTM: Comprehensive framework metadata
The added metadata provides an excellent overview of Ts.ED framework with relevant keywords.
packages/orm/prisma/src/generator/domain/DmmfModel.ts (2)
70-70: Avoid parameter reassignment
Reassigning the moduleSpecifier parameter could lead to maintenance confusion. Consider using a local variable instead.
🧰 Tools
🪛 Biome (1.9.4)
[error] 70-70: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
82-86: Consider impact of sorting imports
While sorting imports improves consistency, this change might affect existing code that relies on import order. Please ensure this doesn't break any dependencies that require specific import ordering.
packages/orm/prisma/package.json (1)
27-27: LGTM! Verify Prisma version consistency
The new script for enum generation aligns well with the PR objective.
✅ Verification successful
Prisma dependencies are in sync at version ^6.0.1
All Prisma-related dependencies in packages/orm/prisma/package.json are consistently using version ^6.0.1:
- @prisma/generator-helper: ^6.0.1
- @prisma/internals: ^6.0.1
- prisma: ^6.0.1
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify Prisma version consistency across the project
jq -r '.dependencies["@prisma/generator-helper"], .dependencies["@prisma/internals"], .devDependencies.prisma' packages/orm/prisma/package.json
Length of output: 166
docs/docs/authentication.md (1)
5-8: LGTM! Documentation improvements
The meta tag updates enhance searchability and provide clearer description of the authentication functionality.
docs/docs/interceptors.md (1)
1-9: LGTM! Well-structured metadata addition.
The metadata changes enhance documentation discoverability with:
- Clear and comprehensive description of interceptor capabilities
- Relevant keywords for SEO optimization
docs/tutorials/vitest.md (1)
1-9: LGTM! Clear and comprehensive metadata.
The metadata accurately describes the Vitest integration guide with appropriate keywords for documentation discovery.
docs/docs/injection-scopes.md (1)
1-9: LGTM! Well-structured metadata addition
The added metadata enhances document discoverability with relevant keywords and an accurate description of injection scopes functionality.
docs/tutorials/vike.md (1)
2-8: LGTM! Comprehensive metadata for Vike tutorial
The metadata structure effectively captures both backend (Ts.ED) and frontend (React, Vue, etc.) aspects of the Vike integration.
docs/tutorials/server-sent-events.md (1)
2-8: 🧹 Nitpick (assertive)
Documentation changes appear unrelated to PR objective
While the metadata restructuring improves documentation organization, these changes seem unrelated to the PR's stated objective of fixing multiple enum imports in Prisma models. Consider submitting documentation improvements as a separate PR to maintain focused change sets.
Let's verify if there are other similar documentation changes across the codebase:
docs/introduction/getting-started.md (1)
2-8: Documentation changes deviate from PR scope
docs/tutorials/terminus.md (1)
2-8: LGTM! Metadata accurately reflects Terminus capabilities.
The metadata changes appropriately highlight:
- Support for both Express.js and Koa.js
- Addition of relevant keywords for monitoring and health checks
docs/docs/custom-providers.md (1)
1-9: LGTM! Comprehensive and well-structured metadata.
The metadata provides:
- Clear description of custom providers' purpose
- Extensive set of relevant keywords covering the ecosystem
- Consistent structure with other documentation files
docs/tutorials/objection.md (1)
2-8: Consistent metadata restructuring.
The changes follow the same pattern as other documentation files.
docs/tutorials/graphql-ws.md (2)
2-8: Consistent metadata restructuring.
The changes follow the same pattern as other documentation files.
2-8: Verify missing Prisma enum-related changes.
The current changes only restructure documentation metadata and don't address the PR's objective of fixing multiple enum imports in Prisma models. Let's verify if there are missing changes:
docs/tutorials/ioredis.md (1)
2-8: LGTM! Metadata structure standardization
The metadata restructuring follows the new documentation standard, maintaining the existing content while improving organization.
docs/tutorials/temporal.md (1)
2-8: LGTM! Consistent metadata structure
The metadata restructuring aligns with the documentation standard while maintaining accurate framework references.
docs/docs/platform-api.md (1)
1-9: LGTM! Well-structured metadata with comprehensive coverage
The metadata restructuring provides clear description and comprehensive keywords that accurately reflect the Platform API's capabilities and supported frameworks.
docs/introduction/create-your-first-controller.md (1)
11-11: LGTM! Keywords update improves documentation discoverability.
The addition of "first" to the keywords list better reflects the content focus on creating the initial controller.
docs/tutorials/graphql-typegraphql.md (1)
2-8: LGTM! Metadata structure improved.
The restructuring of metadata under the 'head' key follows a more organized hierarchical format while maintaining the same content.
docs/tutorials/passport.md (1)
2-8: LGTM! Metadata structure standardized.
The metadata restructuring aligns with the documentation-wide standardization effort, improving consistency while preserving the content.
docs/tutorials/bullmq.md (1)
2-8: LGTM! The metadata changes enhance documentation discoverability.
The added meta tags provide clear description and relevant keywords for the BullMQ integration documentation.
docs/tutorials/typeorm.md (1)
2-8: LGTM! The metadata changes improve documentation searchability.
The added meta tags provide clear description and relevant keywords for the TypeORM documentation.
docs/docs/pipes.md (1)
2-8: LGTM! The metadata changes enhance documentation findability.
The added meta tags provide clear description and relevant keywords for the Pipes documentation.
docs/tutorials/ajv.md (1)
2-8: LGTM! Consistent metadata restructuring.
The metadata has been properly reorganized under a head section, following a consistent pattern across documentation files. This hierarchical structure improves organization and maintainability.
docs/tutorials/socket-io.md (1)
2-8: LGTM! Consistent metadata restructuring.
The metadata follows the same hierarchical structure as other documentation files.
docs/docs/request-context.md (1)
1-9: LGTM! Consistent metadata restructuring.
The metadata follows the same hierarchical structure as other documentation files.
docs/docs/testing.md (1)
1-9: LGTM! Well-structured metadata.
The metadata structure is clean and the content accurately reflects the document's purpose. The keywords are comprehensive and relevant to the testing documentation.
docs/tutorials/mongoose.md (1)
2-8: LGTM! Metadata updated with improved platform coverage.
The metadata structure is consistent with other files, and the addition of 'koa' to keywords appropriately reflects the framework's platform support.
docs/tutorials/serverless.md (1)
2-8: LGTM! Consistent metadata structure.
The metadata is well-organized and follows the established pattern. The description and keywords accurately represent the serverless documentation content.
docs/docs/json-mapper.md (1)
5-5: LGTM! Clear and comprehensive meta description.
The meta description effectively communicates the purpose and capabilities of the @tsed/json-mapper package.
docs/introduction/capabilities.md (2)
5-5: LGTM! Comprehensive meta description.
The description effectively explains Ts.ED's architecture, platform support, and abstraction capabilities.
8-8: LGTM! Well-structured keywords.
The keywords effectively cover all major features and related technologies, improving searchability.
docs/docs/validation.md (2)
5-5: LGTM! Clear and focused meta description.
The description effectively communicates the validation system's purpose and decorator-based approach.
8-8: LGTM! Comprehensive keywords.
The keywords effectively cover validation-specific terms and related technologies.
docs/tutorials/mikroorm.md (1)
2-8: LGTM: Metadata structure updated correctly.
The metadata has been properly restructured under the head section while maintaining the original content.
docs/docs/providers.md (1)
2-8: LGTM: Enhanced metadata content and structure.
The metadata has been properly restructured and improved with:
- More comprehensive description
- Additional relevant keywords (pipes, middlewares, testing)
docs/tutorials/oidc.md (1)
2-8: LGTM: OIDC-specific metadata properly structured.
The metadata has been correctly restructured while maintaining appropriate OIDC-specific content in both description and keywords.
| generator client { | ||
| provider = "prisma-client-js" | ||
| binaryTargets = ["native", "windows", "debian-openssl-1.1.x"] | ||
| output = "../prisma/generated/client" | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
💡 Codebase verification
Based on the gathered information, I can now provide the final response:
Review binary targets in schema.prisma
The current binary targets configuration appears to be more extensive than necessary. The debian-openssl-1.1.x target is used in test schemas but there's no evidence of production deployment requirements for Windows or Debian-specific builds. Unless you have specific cross-platform deployment needs, you can simplify this to just:
binaryTargets = ["native"]This will be sufficient for most deployment scenarios as the native target automatically handles the build for the platform where Prisma Client is generated.
🔗 Analysis chain
Verify binary targets necessity
The client generator includes multiple binary targets. Please verify if all these targets are necessary for your deployment environment.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if these binary targets are referenced in deployment configs
rg -l "debian-openssl-1.1.x" .
rg -l "windows" . | grep -i "deploy\|docker\|config"
Length of output: 317
Script:
#!/bin/bash
# Check deployment and configuration files for any platform-specific settings
fd -e yaml -e yml -e dockerfile -e dockerignore -e env . | xargs cat
# Check package.json files for any platform-specific scripts or dependencies
fd package.json | xargs cat
# Check if there are any platform-specific test files
fd -e test.js -e spec.js -e test.ts -e spec.ts | xargs cat
Length of output: 66456
Script:
#!/bin/bash
# Check if there are any platform-specific build or deployment configurations
fd -e config.js -e config.ts -e config.json . | xargs cat
# Check if there are any Docker files that might indicate deployment platforms
fd Dockerfile . | xargs cat
# Check if there are any CI/CD configurations that might indicate deployment targets
fd -e .github -e .gitlab-ci.yml -e .circleci . | xargs cat
Length of output: 10336
| head: | ||
| - - meta | ||
| - name: description | ||
| content: GraphQL Nexus' APIs were designed with type-safety in mind. We auto-generate type-definitions as you develop, and infer them in your code, giving you IDE completion and type error catching out of the box! | ||
| - - meta | ||
| - name: keywords | ||
| content: ts.ed express typescript graphql websocket node.js javascript decorators |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
LGTM! Enhanced metadata with focus on type-safety.
The updated description effectively highlights Nexus's type-safety features. Consider adding GraphQL and Nexus version compatibility information in the installation section to help users avoid potential version conflicts.
| head: | ||
| - - meta | ||
| - name: description | ||
| content: Start your first Ts.ED project with the CLI or clone a starter project. Ts.ED provides a conventional base structure for your project, making it easy to get started. Choose from a variety of starter projects to find the one that best suits your needs. | ||
| - - meta | ||
| - name: keywords | ||
| content: installation ts.ed framework express koa aws cli di rest graphql typescript node.js bun.js javascript native ESM decorators jsonschema class models providers pipes middlewares testing developer |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Focus PR on core Prisma enum fixes
While documentation improvements are valuable, this PR's primary objective is to fix Prisma enum import issues. I don't see any changes related to that core objective in these files. Consider:
- Removing these documentation changes from this PR
- Creating a separate PR for documentation improvements
- Including the actual Prisma enum fixes that address issue [BUG] [Prisma] Multiple enums on model not correctly imported #2939
This will help maintain clear change scope and make the PR easier to review.
Romakita
force-pushed
the
fix-prisma-enums
branch
from
e1e5d37 to
1f6e346
Compare
|
🎉 This PR is included in version 8.3.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes: #2939
Summary by CodeRabbit
New Features
Bug Fixes
Chores