fix(cache): exclude cache-control with new property #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeveltere
changed the title
pdeveltere
changed the title
|
hello @pdeveltere also to have correct release note you have to write your commit message followings the angular commit convention here: https://www.conventionalcommits.org/en/v1.0.0-beta.4/ See you :) |
Romakita
force-pushed
the
production
branch
4 times, most recently
from
b76e7c8 to
9230a2a
Compare
Romakita
requested changes
Sep 12, 2024
| @@ -136,11 +139,13 @@ export class PlatformCacheInterceptor implements InterceptorMethods { | |||
|
|
|||
| const result = await next(); | |||
|
|
|||
| const calculatedTTL = this.cache.calculateTTL(result, ttl); | |||
| if (!this.disableCacheControl) { | |||
| const calculatedTTL = this.cache.calculateTTL(result, ttl); | |||
There was a problem hiding this comment.
You have an error here. calculatedTTL isn't available after the bloc. You can run the unit test to reproduce issue ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Additional info
Fix for #2774
Todos