Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add connection prop to diode #721

Merged
merged 3 commits into from
Mar 29, 2025
Merged

add connection prop to diode #721

merged 3 commits into from
Mar 29, 2025

Conversation

Anshgrover23
Copy link
Contributor

/claim #719
Fixes #719

@vercel Vercel
Copy link

vercel bot commented Mar 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tscircuit-core-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 4:46pm

@algora-pbc algora-pbc bot mentioned this pull request Mar 29, 2025
Closed
@Anshgrover23 Anshgrover23 requested a review from seveibar March 29, 2025 16:02
seveibar
seveibar requested changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values for pcb component width/hright are weird, im not sure you need to be redefining those functions- at the very least you should make sure that footprints work with a snapshot test if making changes to that fn

@Anshgrover23 Anshgrover23 requested a review from seveibar March 29, 2025 16:20
@Anshgrover23
Copy link
Contributor Author

@seveibar i think you are right no need of that pcb render function for this issue. i have removed that.

seveibar
seveibar requested changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anshgrover23 you've got to read over your code before requesting review, the super calls are clearly not needed!

@Anshgrover23 Anshgrover23 requested a review from seveibar March 29, 2025 16:46
@Anshgrover23
Copy link
Contributor Author

@seveibar i think i misinterpret the functions there is only needed change in props after doing that this all are working fine.

seveibar
seveibar approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, was just the prop definition that was missing

@seveibar seveibar merged commit b75b849 into tscircuit:main Mar 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<diode /> doesn't accept connections prop
2 participants
@Anshgrover23 @seveibar