Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional aliases to transistor ports #625

Merged
merged 6 commits into from
Feb 13, 2025
Merged

add additional aliases to transistor ports #625

merged 6 commits into from
Feb 13, 2025

Conversation

Anshgrover23
Copy link
Contributor

Fixes #581
/claim #581

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tscircuit-core-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 4:28pm

@algora-pbc algora-pbc bot mentioned this pull request Feb 13, 2025
Closed
ShiboSoftwareDev
ShiboSoftwareDev requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a snapshot test connecting to a transistor port using the new port aliases for example: "T1 > emitter", "T1 > c", etc.

seveibar
seveibar approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move your test to a separate file to avoid overriding snapshots? Generally we want one test per file, you can always add “2” to the filename and “1” to the original if you want to reuse the name

@imrishabh18 imrishabh18 merged commit 236f0ac into tscircuit:main Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

@imrishabh18 imrishabh18 imrishabh18 approved these changes

@ShiboSoftwareDev ShiboSoftwareDev ShiboSoftwareDev approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connect to transistor terminals
4 participants
@Anshgrover23 @seveibar @imrishabh18 @ShiboSoftwareDev