fix: autorouter is inhertited by the subcircuit child #610
+98
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
reviewed
Feb 9, 2025
| this.parent._shouldRouteAsync() | ||
| ) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
not the right behavior, this is the correct behavior:
- The props define what the subcircuit should do FIRST
- If the props don't specify what you should do, THEN you look at your subcircuit, not your parent
There was a problem hiding this comment.
you can't do trace-by-trace autorouting until your children have finished autorouting, but that's outside the scope of this function and may already be implemented
seveibar
reviewed
Feb 9, 2025
| if (props.autorouter) return false | ||
| // Inherit from parent if not set by props | ||
| const autorouter = | ||
| this._parsedProps.autorouter ?? this.getInheritedProperty("autorouter") |
seveibar
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue - tscircuit/tscircuit.com#649