feat: Auto adjust board size to fit children components if width/height isn't provided #599
+151
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
reviewed
Feb 9, 2025
| const newProps = getBoardSize(this._parsedProps, this.children) | ||
| // console.log("newProps",newProps); | ||
| if (newProps) { | ||
| this._parsedProps = newProps |
There was a problem hiding this comment.
? you're still setting _parsedProps, which is immutable
seveibar
requested changes
Feb 10, 2025
There was a problem hiding this comment.
you're not allowed to change props, you cannot change props (in any way)
you can create a function like board.getSize() and refactor the code to not use props where it would normally be getting the width/height or whatever
you can't change props, props are the user input, you can create new variables etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #562
Fixes #562